Repository navigation
Lint with oxlint and check formatting and types in CI - #15
Merged
Merged
Conversation
Replace ESLint with oxlint. The complexity cap of 10 carries over unchanged, and type-aware rules from typescript-eslint's recommended-type-checked set now run as well (floating and misused promises, template and plus operands, unnecessary type assertions and similar), excluding the no-unsafe family. Warnings and unused disable directives fail. oxlint also lints the scripts in .astro files, which ESLint skipped, and finds two functions over the complexity cap there. scripts/lint.ts records them per file and rule in lint-suppressions.json: a new violation fails, and a fixed one must be pruned with bun run lint:prune.
Only table alignment changes; rendered pages are identical. Benchmark JSON files are written by Foundry and the measurement scripts, so Prettier leaves them as generated.
The Checks job runs Prettier, the oxlint ratchet and astro check, each reporting even when an earlier step fails. Formatting and types were not checked in CI before. Prettier stays because oxfmt does not format .astro files.
Deploying ekubo-docs with
|
| Latest commit: |
a0c8d6a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6164c03d.ekubo-docs-966.pages.dev |
| Branch Preview URL: | https://ci-fast-checks.ekubo-docs-966.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces ESLint with oxlint and puts formatting, lint and type checks in one CI job.
+operands, unnecessary type assertions and similar), excluding theno-unsafe-*family. Warnings and unused disable directives fail..astrofiles, which ESLint skipped. It finds two functions over the complexity cap there (repairAccessibilityinsrc/pages/api/index.astroand one inPolicyEditor.astro).scripts/lint.tsrecords them inlint-suppressions.json: a new violation fails, and a fixed one must be pruned withbun run lint:prune. They will be fixed separately.bun run format:check(Prettier) now runs in CI. Two Markdown tables had drifted and are realigned in their own commit; rendered pages are unchanged. Generated benchmark JSON is ignored. Prettier stays because oxfmt cannot format.astrofiles.bun run check(astro check) now runs in CI. TypeScript 7 is not used because astro check needs the TypeScript 5 language service for.astrofiles.Local timings: lint 0.4 s (ESLint) → 0.3 s (oxlint with type-aware rules), format check 1.1 s, astro check 5 s.