splice-script: Add more diagnostics and logs - #8962
Open
ddustin wants to merge 1 commit into
Open
Conversation
ddustin
force-pushed
the
ddustin/splice_script_diagnostics
branch
2 times, most recently
from
March 22, 2026 15:19
546636d to
5aea3ed
Compare
Increasing verbosity to make more clear what splice script is doing. Changelog-None
ddustin
force-pushed
the
ddustin/splice_script_diagnostics
branch
from
March 22, 2026 22:02
5aea3ed to
98e5655
Compare
Andezion
reviewed
Jul 29, 2026
| /* First add all sats going into general fund */ | ||
| for (size_t i = 0; i < tal_count(splice_cmd->actions); i++) { | ||
| action = splice_cmd->actions[i]; | ||
| if (amount_sat_is_zero(action->out_sat) && !action->out_ppm) |
Collaborator
There was a problem hiding this comment.
This continue skips the pays_fee block whenever out_sat == 0 && out_ppm == 0 - which is exactly the state of a not yet funded wallet input that is supposed to pay the fee (the case handle_fee_and_ppm triggers this function for). sub_fee_from_general stays true by default instead of being set false, so the fee gets deducted from the general pool instead of being tracked against the paying action
| " in wallets and %d out wallets", | ||
| in_wallet_count, out_wallet_count)); | ||
|
|
||
| if (fee_count > 1) |
Collaborator
There was a problem hiding this comment.
fee_count never incremented anywhere. Is this a dead code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increasing verbosity to make more clear what splice script is doing.