Askrene and xpay improve - #9150

Merged

nGoline merged 29 commits into

ElementsProject:masterfrom

rustyrussell:askrene-and-xpay-improve

Aug 4, 2026

Commits on Aug 3, 2026

multiwithdraw: use unique ids on requests.

rustyrussell
authored and
Lagrang3
committed
ae4a1f5
libplugins: JSON ids are always strings.

rustyrussell
authored and
Lagrang3
committed
9cbfe89
libplugin: json_id: guard against weird prefixes
Lagrang3
committed
5abc690
lightningd: internal cleanups since all non-command JSON IDs are strings.

rustyrussell
authored and
Lagrang3
committed
064ede7
common: hoist hash_str helper into its own header.

rustyrussell
authored and
Lagrang3
committed
a976a10
common: implement str_to_u64, make json_to_u64 use it.

rustyrussell
authored and
Lagrang3
committed
add147d
Add unit tests for str_to_u64
Lagrang3
committed
6ae08f9
common: hoist amount+currency parsing into common code.

rustyrussell
authored and
Lagrang3
committed
81718dd
askrene: add APIs for "impressions" which are *relative* constraints.

rustyrussell
authored and
Lagrang3
committed
10e8d0d
downgrade: we need to remove "impressions" from askrene datastore when downgrading to v26.06.

rustyrussell
authored and
Lagrang3
committed
10ddf2d
downgrade tool: fix invalid memory bug
Lagrang3
committed
e4f1c6c
add a test for downgrading askrene datastore
Lagrang3
committed
ab355bf
xpay: fakenet test: skip temporarily
Lagrang3
committed
febccdc
xpay: actually tell askrene when a payment succeeded.

rustyrussell
authored and
Lagrang3
committed
e450d63
askrene: correctly order constraints.

rustyrussell
authored and
Lagrang3
committed
bcf9017
common: add helper to remove a range of elements
Lagrang3
committed
427d9b7
askrene: don't leak channel intel entries
Lagrang3
committed
d6361ab
xpay: trim constraints: small optimization
Lagrang3
committed
d6b00ff
askrene: safer iterating over changing htable
Lagrang3
committed
22b4d2a
pytest: add tests for what we want askrene to do.

rustyrussell
authored and
Lagrang3
committed
94ec37f
askrene: give clearer error codes.

rustyrussell
authored and
Lagrang3
committed
12b1409
xpay: tests should expect the new error messages
Lagrang3
committed
9303ac7
askrene: explain failure: add known enabled case
Lagrang3
committed
a2f8df9
offers: limit invoices to 10 minutes for recurring offers in other currencies.

authored and
Lagrang3
committed
fd03e45
offers: limit expiry to offer limit, or 10 minutes with currency conversion.

rustyrussell
authored and
Lagrang3
committed
74b5082
fetchinvoice: don't bother with checking recurrence timing.

rustyrussell
authored and
Lagrang3
committed
ff67d5e
lightningd: don't do previous invoice checking in createinvoicerequest.

rustyrussell
authored and
Lagrang3
committed
b3e4919
fetchinvoice: handle weird labels in recurrence_label parameter.

rustyrussell
authored and
Lagrang3
committed
f88c37c

Commits on Aug 4, 2026

askrene: test explain: fix flake
Lagrang3
committed
3a3af52

Navigation Menu

Uh oh!

Askrene and xpay improve - #9150

Askrene and xpay improve#9150
nGoline merged 29 commits into
ElementsProject:masterfrom
rustyrussell:askrene-and-xpay-improve

Commits on Aug 3, 2026

multiwithdraw: use unique ids on requests.

libplugins: JSON ids are always strings.

libplugin: json_id: guard against weird prefixes

lightningd: internal cleanups since all non-command JSON IDs are strings.

common: hoist hash_str helper into its own header.

common: implement str_to_u64, make json_to_u64 use it.

Add unit tests for str_to_u64

common: hoist amount+currency parsing into common code.

askrene: add APIs for "impressions" which are relative constraints.

downgrade: we need to remove "impressions" from askrene datastore when downgrading to v26.06.

downgrade tool: fix invalid memory bug

add a test for downgrading askrene datastore

xpay: fakenet test: skip temporarily

xpay: actually tell askrene when a payment succeeded.

askrene: correctly order constraints.

common: add helper to remove a range of elements

askrene: don't leak channel intel entries

xpay: trim constraints: small optimization

askrene: safer iterating over changing htable

pytest: add tests for what we want askrene to do.

askrene: give clearer error codes.

xpay: tests should expect the new error messages

askrene: explain failure: add known enabled case

offers: limit invoices to 10 minutes for recurring offers in other currencies.

offers: limit expiry to offer limit, or 10 minutes with currency conversion.

fetchinvoice: don't bother with checking recurrence timing.

lightningd: don't do previous invoice checking in createinvoicerequest.

fetchinvoice: handle weird labels in recurrence_label parameter.

Commits on Aug 4, 2026

askrene: test explain: fix flake