Bump NBitcoin to 10.0.9 and NBXplorer.Client to 5.0.8

[Jossec101]

Paired bump: NBXplorer.Client 5.0.8 targets net10.0 and requires
NBitcoin >= 10.0.8. Also NBitcoin.TestFramework 4.0.2 -> 5.0.2.

NBitcoin 10 removed the NBitcoin.Scripting OutputDescriptor API; its
Miniscript/WalletPolicies replacement only parses BIP388 multipath
descriptors (/**), which NodeGuard's watch-only import explicitly rejects
(only external-chain /0/* keys are accepted). To preserve the exact
accepted grammar and error behavior, WalletParser now parses the small
supported descriptor surface directly (wpkh/pkh/multi/sortedmulti/
wsh(multi), origins, checksum validation) and renders export descriptors
manually with Miniscript.AddChecksum for the BIP380 checksum. The
lexicographical-order test rebuilds the descriptor from the multisig
script parameters since OutputDescriptor.InferFromScript is gone.

All 389 tests pass, including the pinned descriptor parse/export vectors
(checksums, key ordering, error types).

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[Copilot]

Pull request overview

Updates NodeGuard’s Bitcoin/NBXplorer dependencies to NBitcoin 10 / NBXplorer.Client 5.0.8 (net10.0), and replaces removed NBitcoin OutputDescriptor APIs with a local, limited output-descriptor parser/renderer to preserve NodeGuard’s supported descriptor surface and checksum behavior.

Changes:

• Bump NBitcoin to 10.0.9, NBXplorer.Client to 5.0.8, and NBitcoin.TestFramework to 5.0.2.
• Rework WalletParser to parse/render the supported descriptor subset without relying on removed NBitcoin.Scripting.OutputDescriptor.
• Update wallet lexicographical-order test to rebuild sortedmulti(...) from extracted multisig script parameters.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/NodeGuard.Tests/NodeGuard.Tests.csproj	Bumps NBitcoin.TestFramework to align with NBitcoin 10 dependency chain.
test/NodeGuard.Tests/Data/Models/WalletTests.cs	Replaces removed OutputDescriptor.InferFromScript usage with multisig script parameter extraction.
src/NodeGuard.csproj	Updates NBitcoin and NBXplorer.Client package versions to required net10.0-compatible releases.
src/Helpers/WalletParser.cs	Implements a custom descriptor parser and manual descriptor rendering with checksum support.
src/Data/Models/Wallet.cs	Removes obsolete NBitcoin.Scripting import after NBitcoin 10 upgrade.

Suppressed comments (1)

src/Helpers/WalletParser.cs:142

• ExtractFromKey returns null for the returned key-origin tuple array when no origin is provided. Callers (and ExtractFromMulti via SelectMany) assume this array is non-null, which can lead to NullReferenceException or confusing import failures for descriptors without "[fingerprint/path]" origins. It’s safer to reject keys without origin info with a clear FormatException.

            if (keyOriginInfo == null)
                return (strategy, null);

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.