Skip to content

fix(chat) Fix chat options are not working (tab spacing/spacing to panel/align tabs to full panel) - #1707

Open
toanqc wants to merge 1 commit into
EllesmereGaming:mainfrom
toanqc:fix_chat_tab_spacing
Open

fix(chat) Fix chat options are not working (tab spacing/spacing to panel/align tabs to full panel)#1707
toanqc wants to merge 1 commit into
EllesmereGaming:mainfrom
toanqc:fix_chat_tab_spacing

Conversation

@toanqc

@toanqc toanqc commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

The chat options aren't working at all. This PR fixes:

The PR also works if the sidebar icon is set to the right side

How was it tested?

Tested directly in-game

Screenshots

Before
"Bottom Spacing to Panel" does nothing
"Align Tabs to Full Panel" does nothing

After
after_3

Checklist

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

@toanqc toanqc changed the title fix(chat) Fix chat options are not working correctly (tab spacing/spacing to panel/align tabs to full panel fix(chat) Fix chat options are not working (tab spacing/spacing to panel/align tabs to full panel) Aug 24, 2026
@toanqc
toanqc marked this pull request as draft September 8, 2026 02:17
@toanqc
toanqc force-pushed the fix_chat_tab_spacing branch from 1e9ea88 to ed79f91 Compare September 8, 2026 02:30
@toanqc
toanqc marked this pull request as ready for review September 8, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant