Fix locale font on the first-install popup - #1985
Merged
EllesmereGaming merged 1 commit intoSep 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The first-install popup can show missing-glyph boxes on a localized client before the options addon has initialized
EllesmereUI._font. Its hard-coded Expressway fallback cannot render Chinese. Use the existing locale-awareGetFontPath()resolver so the initial setup labels are readable. The core defines this resolver before the popup file loads.How was it tested?
Fonts\ARKai_T.ttf; the Reload UI button still applies the existing selections.git diff --check, and the repository's locale-key regeneration check pass (781 keys, no generated-file changes).Screenshots
Before:
After:
Checklist