Skip to content

Fix independent party Show AFK setting - #1986

Open
hiltay wants to merge 1 commit into
EllesmereGaming:mainfrom
hiltay:fix/party-afk-setting
Open

Fix independent party Show AFK setting#1986
hiltay wants to merge 1 commit into
EllesmereGaming:mainfrom
hiltay:fix/party-afk-setting

Conversation

@hiltay

@hiltay hiltay commented Sep 6, 2026

Copy link
Copy Markdown

What does this PR do?

Fix the existing Show AFK toggle when Party > Indicators is customized independently of raid settings. statusShowAFK was missing from the Indicators section map, so the party toggle wrote the raid setting and saved party_statusShowAFK overrides were ignored by the party proxy.

Adding the existing key to its section makes party reads, writes, and frame rendering use the custom party value. Synced party settings still inherit the raid value. This is a one-line bug fix with no new settings or duration feature.

How was it tested?

  • Live macOS client 12.1.0.69587, zhCN, using the real player unit in the party frame's existing solo display mode and /afk.
  • With indicator sync off, party Show AFK on, and raid Show AFK off: upstream rendered no AFK text (effective party value false); the one-line patch rendered the localized AFK label (effective value true).
  • Re-enabling indicator sync restored the raid value and hid the AFK label.
  • Six offline behavioral checks execute the production setting helpers, proxies, and status painter with WoW API substitutes: upstream fails three cases; this patch passes all six. Checks cover custom enable/disable, stored overrides, synced inheritance, unset overrides, and defaults. Run with Lua 5.1 and the checkout path as its argument. These do not replace live-client testing.
  • Lua 5.1 syntax, git diff --check, and the repository's locale-key regeneration check pass (781 keys, no generated-file changes).

Screenshots

The diagnostic line lists: player AFK, indicator sync, party setting, raid setting, effective party setting. The real party player frame is at the upper left.

Before (effective value false; no AFK label):

Party override ignored before the fix

After (effective value true; AFK label visible):

Party override applied after the fix

Checklist

  • New settings default OFF (N/A: no new settings; existing defaults unchanged)
  • Zero cost while disabled: no new events, polling, hooks, or frames
  • Cheap while enabled: uses the existing settings map and repaint paths
  • No writes onto Blizzard-owned frames; no hook or script changes
  • Tested in-game on live; no version gates or pre-Midnight APIs added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant