Fix independent party Show AFK setting - #1986
Open
hiltay wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the existing Show AFK toggle when Party > Indicators is customized independently of raid settings.
statusShowAFKwas missing from the Indicators section map, so the party toggle wrote the raid setting and savedparty_statusShowAFKoverrides were ignored by the party proxy.Adding the existing key to its section makes party reads, writes, and frame rendering use the custom party value. Synced party settings still inherit the raid value. This is a one-line bug fix with no new settings or duration feature.
How was it tested?
/afk.git diff --check, and the repository's locale-key regeneration check pass (781 keys, no generated-file changes).Screenshots
The diagnostic line lists: player AFK, indicator sync, party setting, raid setting, effective party setting. The real party player frame is at the upper left.
Before (effective value false; no AFK label):
After (effective value true; AFK label visible):
Checklist