Skip to content

Fix the invite / whisper functionality. - #1988

Open
RedAces wants to merge 1 commit into
EllesmereGaming:mainfrom
RedAces:fix-social-plugin
Open

Fix the invite / whisper functionality.#1988
RedAces wants to merge 1 commit into
EllesmereGaming:mainfrom
RedAces:fix-social-plugin

Conversation

@RedAces

@RedAces RedAces commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

I had weird bugs where I couldnt invite friends from the social plugin on the minimap. They just wouldnt get my invites. No chat message either like "Youve invited friend-realm to your party." Left clicking them showed that the realm was added multiple times: The whisper frame showed "To charname-realm-realm-..."

It fixed itself after awhile. IDK when or how.

How was it tested?

Tested on 12.1 retail infight and outfight.

Checklist

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

Sometimes the realm was added twice or thrice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant