Fix Extra Action Button staying hidden until reload - #1989
Merged
EllesmereGaming merged 1 commit intoSep 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Extra Action Button staying invisible after an EUI visibility condition clears, until
/reload.The visibility paths could hide EUI's movable holder, but both restore paths excluded movable holders. Restore the holder in
RefreshRuntimeVisibilityandUpdateHousingVisibilitywhen the existing visibility evaluator permits it. This also covers the Encounter Bar, which uses the same holder path.Blizzard retains control of the child frames. Restoration remains outside combat and respects disabled/hidden settings, visibility modes, and pet battles. No new events, polling, timers, or frames are added; the change reuses the existing visibility evaluator during refreshes.
How was it tested?
EUI-extra-action-wrapper-test.zipfixed the reported issue in game.main.luac5.4.6. The EUI style gate passed its Lua 5.1 compatibility and ASCII checks.Screenshots
Before/after screenshots are not available. The user confirmed the test ZIP's behavior; no screenshots are claimed.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames - Changed Show calls target EUI-owned holders; no new Blizzard-frame fields or scripts.