fix(nameplates): boss with a mana pool coloured as Spell Caster - #1990
Merged
EllesmereGaming merged 2 commits intoSep 7, 2026
Merged
Conversation
Boss units are detected up front but their colour is deferred to step 10b, below the threat-colour steps. The Caster check at step 8 is a plain mana-pool test with no boss exclusion, so any boss that also has mana -- Imperator Averzian, for one -- returned there and never reached 10b. Mini-boss does not have this bug because step 7 returns above the Caster check. Excluding bosses from the Caster test gives boss and caster the same mutual exclusivity boss and mini-boss already have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix from Svart. Reported as Imperator Averzian showing the Spell Caster colour
instead of Bosses.
Root cause
In
GetReactionColor's colour-priority chain, boss units are detected up frontbut their colour is deliberately deferred to step 10b, below the threat-colour
steps. The Caster check at step 8 is a plain mana-pool test with no boss
exclusion, so a boss that also has a mana pool returns there and step 10b is
never reached.
Mini-boss does not have this bug: step 7 returns above the Caster check, so the
two are already mutually exclusive.
Fix
One line: bosses are excluded from the Caster test, giving boss/caster the same
mutual exclusivity boss and mini-boss already have. Plus a comment recording why
the exclusion is needed here and not for mini-boss.
Testing
luac -pclean; house style check clean. Not click-tested by me -- Svartreported it from the encounter. Any mana-using boss reproduces it; a boss
without mana is unaffected either way.