fix(nameplates): boss colour lost to the No Aggro colour on engage - #1991
Merged
EllesmereGaming merged 2 commits intoSep 7, 2026
Merged
Conversation
Tanks already had tankHasAggroOverrideBoss to keep the Boss colour while holding aggro. The DPS/healer No Aggro step returned unconditionally with no boss exclusion, so a boss lost its colour the moment a non-tank engaged, with nothing to turn that off -- even though the other two mob-type categories, Mini-Boss and Caster, both already had their own override toggles there. Adds dpsNoAggroOverrideBoss and gates step 10 on it, mirroring the tank side. Default off, matching its siblings, so bosses keep their colour out of the box. The matching "Override Boss colors" toggle is on the No Aggro cog popup, under the label the tank side already uses.
…written-by-threat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix from Svart. Reported as the Boss colour being lost the moment a DPS/healer
engages.
Root cause
Tanks already had
tankHasAggroOverrideBoss(default on) to choose whether theBoss colour survives while they hold aggro. The DPS/healer No Aggro step (10)
returned unconditionally with no boss exclusion at all, so a boss lost its
colour on engage with no way to turn that off.
Both other mob-type categories at that step, Mini-Boss and Caster, already had
their own override toggles (
dpsNoAggroOverrideMiniBoss,dpsNoAggroOverrideCaster, both off by default). Boss was the one categorymissing its sibling -- an omission rather than a deliberate asymmetry.
Fix
Adds
dpsNoAggroOverrideBossand gates step 10 on it, mirroring the tank side'sexisting
ovrBosspattern at step 9. The matching "Override Boss colors" togglegoes on the No Aggro cog popup, reusing the label the tank side already uses.
Note on the default
Default is off, matching its two siblings, so bosses keep their colour out of
the box. That is a visible behaviour change for existing DPS/healer users: today
a boss always loses its colour on engage, and after this it keeps it unless the
new toggle is switched on. That is the point of the fix, but it is a default
change rather than a purely additive setting, so it is worth being deliberate
about. The tank-side sibling defaults on, which is the opposite -- that
asymmetry is pre-existing and untouched here.
Testing
luac -pclean on both files; house style check clean. Not click-tested by me.Worth confirming in game: the new toggle appears on the No Aggro cog, bosses keep
their colour with it off, and behave as before with it on.