fix(unitframes): give Boss/Pet/ToT/Focus Target their own frame border - #1992
Open
dfrisone wants to merge 1 commit into
Open
fix(unitframes): give Boss/Pet/ToT/Focus Target their own frame border#1992dfrisone wants to merge 1 commit into
dfrisone wants to merge 1 commit into
Conversation
Boss frames always drew a plain default border however the border texture was configured, while Target picked the custom one up correctly. Two layers: The options UI only ever offered a Border Style/Size section for Player/Target/Focus, so the other four had no way to set a border at all -- "Solid" by omission rather than a rendering fault. With that added the setting still did not show, because ReloadFrames has a second border pass for mini/boss frames that re-applied the DONOR's border over the unit's own, moments after UpdateBordersForScale had just drawn it. That was left from before these frames had a border of their own. It now reads each unit's own settings. The same donor convention in the options preview widget is fixed the same way, which is why the mockup was wrong in exactly the same manner. borderSizeOverride is retired: it existed only to vary the donor's size, and a real per-unit borderSize replaces it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix from Svart. Reported as the Boss frame always drawing a plain default border
however the border texture was configured, while Target picked the custom one up
correctly. Pet, Target of Target and Focus Target turned out to have it too.
Root cause, two layers
Missing control. The options UI only ever offered a Border Style/Size section
for Player/Target/Focus. Boss/Pet/ToT/Focus Target had no way to set a frame
border at all, so they were "Solid" by omission rather than by a rendering fault.
Donor overwrite, the actual blocker. With the control added the setting still
did not appear live.
ReloadFrameshas a second border pass for mini/boss framesthat unconditionally re-applied the donor's border (Player/Target/Focus) over
the unit's own, moments after
UpdateBordersForScalehad already drawn the rightone in the same pass. Left over from before these frame types had a border of
their own. The identical donor convention in the options-panel preview widget had
the same effect, which is why the mockup was wrong in exactly the same way.
Changes
colour swatch) on Boss, Pet, ToT and Focus Target, under Display on all four
ReloadFrames's second border pass reads each unit's own settingsNote:
borderSizeOverrideis retired, with no migrationIt existed only to vary the donor's size for ToT/Focus Target/Pet, and a real
per-unit
borderSizereplaces it. Anyone who had set it will find the valueorphaned in their saved variables and their border size back at the default until
they set the new control. Small, but it is a silent reset rather than a carry-
over, so worth being deliberate about before this merges.
Testing
luac -pclean on both files; house style check clean. Not click-tested by me --Svart reported and fixed it from live play. Worth confirming: a custom SharedMedia
border texture set on Boss shows on a real Boss frame and in Activate Boss
Preview, and Player/Target/Focus are unchanged.