feat(macrofactory): drop the Nature's Swiftness / Convoke druid macro - #1994
Merged
EllesmereGaming merged 1 commit intoSep 7, 2026
Merged
Conversation
Reported by Goat: Nature's Swiftness no longer buffs the Regrowths a Convoke casts, which was the whole reason to macro the two together. With Overgrowth taken it is now actively harmful, since the channel's first Regrowth moves Lifebloom onto whoever it lands on. Removed from the Restoration list. Macros already created keep working and are untouched; the factory only ever deletes one when the user clicks Delete Macro. The translations for the label stay in the locale files, so nothing breaks if it is ever brought back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @goat (QoL, 9.1.6): the Macro Factory still offers a Nature's
Swiftness / Convoke macro for Restoration druids, and pairing them is no longer
a good idea.
Why it goes
Nature's Swiftness no longer buffs the Regrowths that Convoke casts, which was
the entire reason to macro the two together. It is now worse than neutral: with
Overgrowth taken, the first Regrowth of the channel moves Lifebloom onto
whoever that Regrowth happens to land on, so a new user pressing the macro
loses their Lifebloom placement without being told why.
That makes it a trap for exactly the people the Macro Factory is aimed at, which
is how it was found: a new EllesmereUI user opening QoL as Resto.
What this does and does not touch
Removed from
DRUID_RESTOonly. Nothing else in the factory changes.Macros a user has already created are left alone and keep working. The factory
only deletes a macro when the user clicks Delete Macro on that entry, so nothing
disappears from anyone's macro list on update; the entry simply stops being
offered.
The localized label stays in the locale files. It is a runtime key rather than a
static one, so
_keys.txtdoes not change (verified by running.tools/extract-locale-keys.sh: no diff), and if the macro is ever brought backthe translations are still there.
Testing
luac -pclean; house style check clean. Click-tested: QoL opens on a Restodruid with the entry gone and the remaining Resto macros still building.