Skip to content

Fonts: say what Global Font covers, and what it does not - #2000

Closed
dfrisone wants to merge 1 commit into
EllesmereGaming:mainfrom
dfrisone:fix/global-font-quest-spellbook
Closed

Fonts: say what Global Font covers, and what it does not#2000
dfrisone wants to merge 1 commit into
EllesmereGaming:mainfrom
dfrisone:fix/global-font-quest-spellbook

Conversation

@dfrisone

@dfrisone dfrisone commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a tooltip to the Global Font dropdown. No behavior change.

Global Font styles EllesmereUI's own text. Blizzard's own text is left on the game face unless Apply to All Game Text is enabled, which is off by default. That row had no tooltip at all, so someone who picked a font and then saw the quest log, spellbook and achievements keep the default face had nothing to read on the control they had just used, and no reason to look further down the section.

The Apply to All Game Text toggle already explains this well, but its tooltip only helps once you have found the toggle.

Reported by @fource, who had set a global font and asked why quest text and the spellbook still differed, and apologised in case it was a stupid question. It was not; there was nothing on screen to tell them.

How was it tested?

Text-only change to one options row. Verified the file still compiles under Lua 5.1 (luac -p) and that the tooltip renders in the same position as the sibling Outline Mode row, which is the only other tooltip in that block.

No locale key change: option row tooltip= fields are plain strings, not EllesmereUI.L() calls, and re-running .tools/extract-locale-keys.sh leaves EllesmereUILocales/_keys.txt byte-identical.

Screenshots

Not included; the change is one tooltip string on an existing control.

Checklist

  • New settings default OFF (no behavior change without opt-in) -- N/A, no new settings
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations) -- a static string on an options row
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames -- N/A
  • Tested in-game on live; no version gates or pre-Midnight APIs added

Global Font styles our own text; Blizzard's is left alone unless Apply to All
Game Text is on. The row had no tooltip at all, so someone who set a font and
saw the quest log and spellbook keep the game face had nothing to read and no
reason to look further down the section. Reported that way.

The toggle's own tooltip already explains it, which is only useful once you
have found the toggle.
@dfrisone

dfrisone commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Closing this: the premise is wrong.

This PR documents "Apply to All Game Text" as the answer for Blizzard text
keeping the game font. A tester has since confirmed that with both toggles
enabled, some Blizzard text still does not take the font -- the Premade Groups
category list shows Questing in a different face from Delves, Dungeons
and the rest.

So the tooltip would point users at a switch that does not do what it says, and
it is worse than the silence @fource originally ran into, because it turns an
undocumented gap into a documented promise the code does not keep.

It is also understood that removing the game-text option entirely has already
been floated, in which case adding a tooltip advertising it is the wrong
direction.

Opening an issue instead to get a decision on the option's future. If the
outcome is that it stays, a corrected tooltip that admits the limitation can
come back with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant