fix(blizz): stop comparing one-handed weapon upgrades against shields without dual wield - #2013
Merged
EllesmereGaming merged 1 commit intoSep 8, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a one-handed weapon being listed as an upgrade over a shield for a character that cannot dual wield. Reported by Zuo on 9.1.6: a Holy paladin with a 295 main-hand mace and 272 shield was told a 279 bag mace was better.
INVTYPE_WEAPONcompares against both weapon slots. The scanner now checksCanDualWield()once per scan and excludes slot 17 for one-handed/off-hand weapons when dual wield is unavailable. A real main-hand upgrade still qualifies; shields and held off-hands retain their normal comparisons.This covers a different case from #736, whose protection for an empty off-hand behind a two-handed weapon remains intact. Existing equipment/spec-change and sheet-open cache invalidation is unchanged.
How was it tested?
Screenshots
The before screenshot was supplied with the report but is not attached here. An after screenshot is not available; in-game confirmation is recorded above.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames -- no frame writes or hooks in the diff.