Fix Warlock FocusKick alerts during interrupt cooldowns - #2017
Merged
EllesmereGaming merged 1 commit intoSep 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix FocusKick treating Command Demon as ready while the active Warlock command is on cooldown. Resolve a known active spell override before accepting the stored base spell as known, so the readiness check uses Spell Lock or Axe Toss rather than stopping at Command Demon.
The stored selection is preserved. Existing base-spell and pet-bank fallbacks remain unchanged, and the override is resolved on each existing check so pet/talent changes do not require a cached mapping. Reported by matrixsage on 9.1.4.
How was it tested?
isActivefield.Screenshots
N/A: cooldown sound gating fix; no visual layout change. The report's spellbook/settings screenshots and an after screenshot are not attached.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames - no frame writes or script changes in this diff.