MythicTimer: reserve threshold-label space early for Gaps style too - #2020
Merged
EllesmereGaming merged 1 commit intoSep 8, 2026
Merged
Conversation
Gaps style (timerBarStyle == "SEGMENTS") renders the threshold time labels above the timer bar, the same as Under Timer Bar mode. But the code only reserved vertical space for that row before positioning the bar when Enemy Forces Position was set to Under Timer Bar. With Bottom selected, the reservation ran after the bar instead, leaving nothing held open between the clock text and the bar -- so with Gaps style and Enemy Forces Position=Bottom, the threshold labels rendered directly on top of the main clock text. Reserve the space early whenever Gaps style is active, not just in Under Timer Bar mode, matching the pattern already used correctly there. Fix from Svart. His GitHub account is currently suspended, so this is being submitted on his behalf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix from Svart. His GitHub account is currently suspended, so this is being submitted on his behalf.
What does this PR do?
Fixes Mythic+ Timer's threshold time labels (e.g. 19:12/02:36) rendering directly on top of the main clock text (e.g. 23:00/32:00) when Thresholds style is set to Gaps and Enemy Forces Position is set to Bottom.
Gaps style renders the threshold labels above the timer bar, the same as Under Timer Bar mode. But the code only reserved vertical space for that row before positioning the bar when Enemy Forces Position was Under Timer Bar. With Bottom selected, that reservation ran after the bar instead, leaving nothing held open between the clock text and the bar.
Fix: reserve the space early whenever Gaps style (
timerBarStyle == "SEGMENTS") is active, not just in Under Timer Bar mode, matching the pattern already used correctly there.How was it tested?
Author-tested by Svart; not independently retested in-game by me before opening this on his behalf.
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames -- N/A, this only affects EllesmereUI's own timer frame layout