Return errors from decimal conversions - #82
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decimal_from_i128_with_scaleanddecimal_mantissareturnResultinstead of panicking on invalid scale or coefficients outsidei128U128coefficient, preserving minimal two's-complement output without narrowingThis mirrors the fix requested during review of JanKaul/iceberg-rust#405.
Performance
The successful constructor path no longer allocates intermediate strings or parses them back into
D128. Decimal manifest serialization remains infallible and uses the fixed-width coefficient directly.Verification
cargo +1.95.0 test -p iceberg-rust-spec spec::decimal::testscargo +1.95.0 test -p datafusion_iceberg converts_precision_38_decimal_bound_to_datafusioncargo +1.95.0 clippy -p iceberg-rust-spec -p datafusion_iceberg --all-targets -- -D warnings