Back off briefly when a pipe pull cannot be delivered anywhere - #1380
Open
RasmusKD wants to merge 1 commit into
Open
Back off briefly when a pipe pull cannot be delivered anywhere#1380RasmusKD wants to merge 1 commit into
RasmusKD wants to merge 1 commit into
Conversation
A sticky piston on a blocked network re-walked the whole pipe on every pulse, pulled a stack, found no room, and returned it as leftovers, repeating the full traversal (and any chunk loads along the route) forever. When a pull delivers nothing at all, the piston now waits before pulling again, configurable via 'full-pipe-cooldown' (seconds, default 2, 0 disables). While paused, requests that carry items (another mechanic feeding the piston) still buffer into the source container, so nothing is dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sticky piston on a blocked network re-walks the whole pipe on every pulse: pull a stack, find no room anywhere, take it back as leftovers, repeat. On clocked systems that is a full traversal (plus any chunk loads along the route) per pulse, forever, moving nothing.
When a pull delivers nothing at all, the piston now waits before pulling again. Configurable via 'full-pipe-cooldown' (seconds, default 2, 0 disables). A partly delivered pull is not paused.
While paused, requests that carry items (another mechanic feeding the piston) still buffer into the source container, so nothing is dropped.
Same pull-loop area as #1376/#1378, happy to rebase whichever lands last.