feat: fully implement Player#sendFakeBlock - #3009
Open
Timongcraft wants to merge 6 commits into
Open
Conversation
Timongcraft
force-pushed
the
feat/fully-impl-fake-block
branch
from
August 17, 2026 13:31
b1822f7 to
3d668ae
Compare
fix: impl in general -> was missing a setLevel call -> using public factory method instead of internal constructor like in core module tested on spongevanilla-1.21.10-17.0.0 (sponge's stable) (26.2 and their latest snapshot 26.3 both have issues)
Timongcraft
force-pushed
the
feat/fully-impl-fake-block
branch
from
August 17, 2026 16:49
3d668ae to
1ab67d3
Compare
Timongcraft
marked this pull request as ready for review
August 17, 2026 16:52
Author
|
I'm not sure if the old |
…getBlockEntity), also different name in spigot -> replace round-tripping through TileState with only the type parsing chore: refactor core impl to also directly parse the BE type id chore: fixup indentation tested on paper 26.2-112 & spigot 26.2 4647-Spigot-8db49a2-efaae75 (spigot has issues unrelated to this pr though)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to improves the
Player#sendFakeBlockimplementation to support non structure-blocks (used by the CUI).Description
Replaces the structure block specific implementation with a generic implementation to allow API users to send fake blocks containing NBT such as player heads, banners etc.
TODO