fix(install): download binary under asset name before checksum check#75
Merged
Conversation
- Add 🌐 Website link pointing to seshat-ai.com in header links - Rename docs/images/nexus.png → docs/images/seshat.png
sha256sum --check looks for the filename listed in SHA256SUMS.txt (e.g. seshat-linux-amd64). The binary was being saved as 'seshat' before verification, so sha256sum could not find the file and aborted. Fix: download to $TMP_DIR/$BIN_ASSET, verify against SHA256SUMS.txt, then rename to 'seshat' only after the check passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
`sha256sum --check` reads SHA256SUMS.txt and looks for each listed filename in the current directory. SHA256SUMS.txt contains entries like:
```
abc123... seshat-linux-amd64
```
The binary was being downloaded as `$TMP_DIR/seshat` (final name), so `sha256sum` could not find `seshat-linux-amd64` and aborted with "No such file or directory".
Fix
Download the binary to `$TMP_DIR/$BIN_ASSET` (keeping the asset name), run the checksum check, then rename to `seshat` after it passes.