Feat: implement cache on imports#99
Open
dnitsch wants to merge 13 commits into
Open
Conversation
This includes caching import files and storing them for copying to dest
|
ElvenSpellmaker
left a comment
ElvenSpellmaker
left a comment
Contributor
There was a problem hiding this comment.
Generally looks OK, you have a few Sonar errors though about complexity
Also, how does this store the files? Does it take into account the version, can you have multiple different versions cached?
Also - we need a mechanism to refresh the cache - currently if I'm on a branch it'll never pick up any new changes to that branch.
Co-authored-by: Jack Blower <ElvenSpellmaker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache is implemented on the first run of the imports - it works for both config only and file imports (i.e. an import with
srcanddest)Cache is stored globally in the
$HOME/.eirctl/cache/*directory.The entire path is base62Encoded so for example
git::ssh://github.com/Ensono/eirctl-shared-utils//build/php/eirctl.yaml?ref=v0.2.267can be referenced from multiple places and will be retrieved from cacheFor projects with many git and https style imports the difference can be up to 20X faster on cached retrieval runs.
Closes #60