refactor(observability): move backend presets out of core#1399
Conversation
|
Code review result: changes requested (GitHub would not allow a formal request-changes review from the PR owner account). Findings:
Verification:
Other notes: I confirmed the vendor-specific backend presets are no longer in |
Deploying agentv with
|
| Latest commit: |
c4c3de7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8364f287.agentv.pages.dev |
| Branch Preview URL: | https://av-otel-backend-resolvers.agentv.pages.dev |
Addressed in
Validation run locally:
CI is currently running on the pushed commit. |
|
CI update for Passed checks: Build, Typecheck, Lint, Test, Check Links, Validate Evals, Validate Marketplace, and Cloudflare Pages. |
|
Re-review result for Verified:
Validation run:
Residual notes:
|
Summary
AgentV still supports the existing
--otel-backend langfuse|braintrust|confidentnames, but backend endpoint/header logic no longer lives in@agentv/core. Core now owns only generic OTLP exporter behavior and generic resolver/resource-attribute types; the CLI owns resolver lookup for current user-facing backend names, and Phoenix-specific endpoint/header/project routing is exported from the Phoenix adapter boundary.Design Notes
packages/coreno longer exportsOTEL_BACKEND_PRESETSor contains Langfuse, Braintrust, Confident, DeepEval, or Phoenix backend env-var routing..agentv/otel-backends/<name>.ts|js|mts|mjsfirst, then falls back to the existing built-in names so current--otel-backendusage keeps working.phoenixOtelBackendlives inpackages/phoenix-adapterand maps Phoenix collector endpoint, client headers, API key auth, andPHOENIX_PROJECT_NAMEto generic OTLP exporter inputs.Red/Green UAT
bun apps/cli/src/cli.ts eval run examples/features/assert/evals/dataset.eval.yaml --dry-run --test-id contains-check --otel-file /tmp/agentv-otel-uat-ClFG7d/trace.otlp.json --output /tmp/agentv-otel-uat-ClFG7d/runwrote an OTLP JSON file containingresourceSpans.Validation
bun test packages/core/test/observabilitybun test apps/cli/test/commands/evalbun test packages/phoenix-adapter/test/otel-backend.test.tsbun run typecheckbun run lintbun apps/cli/src/cli.ts eval --help | rg -n "otel|backend|trace"produced no matches because top-level eval help only lists subcommands.bun apps/cli/src/cli.ts eval run --help | rg -in "otel|backend|trace"bun run validate:examples