feat(copilot): flat pi-style provider config, SDK args, ACP custom providers#1402
Draft
christso wants to merge 2 commits into
Draft
feat(copilot): flat pi-style provider config, SDK args, ACP custom providers#1402christso wants to merge 2 commits into
christso wants to merge 2 commits into
Conversation
…oviders - Remove custom_provider/byok nested objects (same-week pre-release, converge to flat) - Add flat subprovider/base_url/api_key/api_version/wire_api fields matching pi-cli style - copilot-sdk: pass args field as cliArgs to CopilotClient - copilot-cli: custom providers now run in ACP mode (preserves tool-call capture) - copilot-cli ACP spawn: set cwd so --plugin-dir ./relative resolves from eval workspace - Precise vscode-jsonrpc node vs node.js diagnostic in copilot-sdk - Update docs, validator, and tests
Deploying agentv with
|
| Latest commit: |
48b76f1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4585c635.agentv.pages.dev |
| Branch Preview URL: | https://feat-copilot-openai-provider.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copilot targets now use the same flat provider configuration shape as
pi-cli, so OpenAI-compatible gateways can be configured without wrappingbase_urland credentials in same-week pre-releasecustom_providerorbyokobjects. The nestedcustom_provider/byokYAML surfaces were removed before release, while the internal resolvedcustomProvidershape remains for CLI env construction and SDK session setup.This also closes the evaluation gaps WTG hit when running Copilot against an OpenAI LLM gateway: SDK target
argsnow pass through ascliArgs, custom providers stay in ACP mode so tool-call capture is preserved, ACP spawns resolve relative plugin paths from the eval workspace, and the SDK import diagnostic now names thevscode-jsonrpc/nodevsnode.jsmismatch with a manual repair command.Config Example
Notes
custom_provider:andbyok:are no longer accepted target fields.subprovidermaps to the Copilot provider type.base_url,api_key,bearer_token,api_version, andwire_apiare resolved from the flat target object.copilot-sdkkeeps the internalcustomProviderresolved config and now forwardsargstoCopilotClientascliArgs.copilot-clicustom provider runs now use ACP mode instead of forced prompt mode.Tests
bun run typecheckbun run lintbun --filter @agentv/core test test/evaluation/providers/copilot-cli.test.ts test/evaluation/providers/copilot-sdk.test.ts test/evaluation/providers/targets.test.ts test/evaluation/validation/targets-validator.test.ts— 101 pass, 0 failbun run verifyPost-Deploy Monitoring & Validation
No additional production monitoring required; this is local eval provider configuration and subprocess behavior. Validate by running a Copilot target against a flat OpenAI-compatible config and checking that
COPILOT_PROVIDER_*env vars are present, ACP tool-call capture remains populated, and relative--plugin-dirpaths resolve from the eval workspace.