Skip to content

Lock protocol run row in update_node_run #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jay-m-dev merged 1 commit into from
Oct 2, 2026
Merged

Lock protocol run row in update_node_run #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/asaree/services/protocol_runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,19 @@ async def update_node_run(
) -> ProtocolRun | None:
"""Shallow-merge *patch* into ``node_runs[node_id]`` -- the same
read-modify-write idiom ``upsert_replicate`` uses for its JSONB columns, one
level deeper (merging into one key of the blob, not the blob itself)."""
run = await get_protocol_run(db, protocol_run_id)
level deeper (merging into one key of the blob, not the blob itself).

The row is locked for the merge: a supervisor's parallel workers each write
their own key concurrently, and an unlocked read-modify-write let one
worker's stale snapshot overwrite a sibling's finished status."""
run = (
await db.execute(
select(ProtocolRun)
.where(ProtocolRun.id == protocol_run_id)
.with_for_update()
.execution_options(populate_existing=True)
)
).scalar_one_or_none()
if run is None:
return None
node_runs = dict(run.node_runs or {})
Expand Down
Loading