Skip to content

Fix/v0.2.0 bugs testing and error path detection - #10

Merged
tiamilani merged 23 commits into
mainfrom
fix/v0.2.0-bugs
Jun 30, 2026
Merged

Fix/v0.2.0 bugs testing and error path detection#10
tiamilani merged 23 commits into
mainfrom
fix/v0.2.0-bugs

Conversation

@tiamilani

Copy link
Copy Markdown
Contributor

Checklist

  • Merged latest main into this branch
  • Lint and tests pass locally
  • New/changed code has tests

What does this PR do?
Fixes correctness and robustness issues, improves error reporting, ensures forward
compatibility, and adds the project's first automated test suite.

Parsing & calculations

  • Validate coordinate systems and reject unsupported/out-of-range inputs.
  • Make the 3 dB beam-border calculation more resilient.
  • Guard beam-efficiency and data-loading against degenerate inputs.
  • Require a schema when validation is requested.

Report generation

  • Handle edge cases gracefully.
  • Fix a circular import and route logging through a module logger.

Compatibility & maintenance

  • Replace deprecated importlib.resources APIs.
  • Internal refactor of the coordinate-transform dispatch and a formatting
    cleanup, with no change to public behavior.

Testing

  • Add a pytest suite with fast, offline fixtures covering the above.

Notes for reviewers

  • Stacked on the vendor-key normalization branch.
  • Public API is unchanged but with better input validation and error detection.
  • The new test suite isn't wired into CI in this PR; the existing lint, type,
    and build checks still run. Verified locally against Python 3.13.

tiamilani added 21 commits June 26, 2026 10:25
Resolves #5 — some 3drp files use 'Theta_Tilt' instead of
'Theta_Electrical_Tilt', causing report generation to fail.
@tiamilani tiamilani self-assigned this Jun 30, 2026
@tiamilani
tiamilani merged commit f4a71df into main Jun 30, 2026
6 checks passed
@tiamilani
tiamilani deleted the fix/v0.2.0-bugs branch June 30, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant