Skip to content

fix: normalize vendor-specific JSON keys to canonical schema names - #11

Merged
tiamilani merged 1 commit into
mainfrom
fix/theta-tilt-key-lookup
Jun 30, 2026
Merged

fix: normalize vendor-specific JSON keys to canonical schema names#11
tiamilani merged 1 commit into
mainfrom
fix/theta-tilt-key-lookup

Conversation

@tiamilani

Copy link
Copy Markdown
Contributor

Resolves #5 — some 3drp files use 'Theta_Tilt' instead of 'Theta_Electrical_Tilt', causing report generation to fail.

Checklist

  • Merged latest main into this branch
  • Lint and tests pass locally
  • New/changed code has tests

What does this PR do?
Some antenna pattern files use a non-standard key name for the electrical tilt
(Theta_Tilt) instead of the schema-canonical Theta_Electrical_Tilt, which
caused report generation to fail. This normalizes known key variants when a
file is loaded, so these files parse and report correctly.

The canonical key is only set when it isn't already present, so files that
already use the standard name are unaffected and no value is overwritten.

Related issues
Closes #5

Notes for reviewers

  • public API is unchanged.
  • This branch contains the fix only. Its automated tests live on the stacked
    v0.2 test branch

Resolves #5 — some 3drp files use 'Theta_Tilt' instead of
'Theta_Electrical_Tilt', causing report generation to fail.
@tiamilani tiamilani linked an issue Jun 30, 2026 that may be closed by this pull request
@tiamilani tiamilani self-assigned this Jun 30, 2026
@tiamilani
tiamilani merged commit 9c71286 into main Jun 30, 2026
6 checks passed
@tiamilani
tiamilani deleted the fix/theta-tilt-key-lookup branch June 30, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generate_report_eas improvements

1 participant