Repository navigation
fix(ci): reserve the room a squash merge takes - #506
Merged
Merged
Conversation
The PR title check measured the title an author types. What lands on main is the squash subject GitHub builds from it, "<title> (#<number>)", which is longer. v1.4.2 went out that way: #496's title was a legal 66 chars and the commit on main is 73, over the 72 this policy enforces -- and `commit messages` then failed on every open PR for a commit none of them wrote. Reserve the suffix before comparing. CI now passes PR_NUMBER so the reserve is exact; a local run without it falls back to the width of a four-digit number. 5 of the 29 PRs open today would still land an over-length subject, so this turns them red before the merge rather than after it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap
check_pr_titlemeasures the title an author types. What lands onmainis the subject GitHub builds from it on squash —<title> (#<number>)— which is longer by 6–9 characters. Nothing checks that one.v1.4.2 went out through that gap. #496's title was
fix(lancedb): cap both caches, give queries their own embed budget, a legal 66 characters. The commit onmainis 73, over the 72 this same policy enforces for commit subjects — socommit messagesthen failed on every open PR, for a commit none of their authors wrote. #505 narrowed the range so those PRs stop being blamed; this closes the hole that produced the subject.It is not a one-off
Of the 29 PRs open today, 5 would still land an over-length subject:
fix(reflection): batch source deprecation, revert it on failure, cap sources per mergefeat(memory): add Decision Memory Kind (extract → persist → index → search → evolve)build(deps): bump the python-deps group across 1 directory with 7 updatesfeat(llm): add aimlapi.com as an LLM endpoint with partner attributionbuild(deps): bump the actions group across 1 directory with 2 updatesEach one that merges puts
commit messagesback in the state #505 just cleaned up, for every PR behind it.The change
Reserve the suffix before comparing. The workflow now passes
PR_NUMBER, so the reserve is the real string — a four-digit PR costs one more character than a three-digit one. A localmake check-pr-titlehas no number and falls back to the width of" (#0000)".The message says what to do:
Verification
Five tests in
tests/unit/test_scripts/test_check_pr_title.py, each failing against the current script:#496and fails at#4096— the reserve is the real suffix, not a guessmain()readsPR_NUMBERmake lintandmake check-commitspass.Expect five PRs to go red
That is the point — they are red now instead of after they have put a bad subject on
main. Each one needs its title shortened, which is a text edit on the PR, no code change and no rebase.