feat: track renderdoc_app.h and regenerate when it moves - #11
Merged
Conversation
Moves CD from binding-simple-cd, which builds and publishes whatever is already committed, to binding-tracked-cd, which reads binding.yml, fetches the header from baldurk/renderdoc, regenerates, and publishes only when the generated API changed. Adds the monthly schedule the other tracked bindings use. This is the first binding generated from a C header to work this way, and the first exercise of the git-tree adapter -- until now only http-file had ever run, in the three XML repositories. The header is currently byte-identical to upstream, so the first run should report nothing changed and publish nothing. That is the intended result and the cheapest possible test of the adapter: a noop that costs one HTTP call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasa el CD de
binding-simple-cd—que compila y publica lo que ya esté commiteado— abinding-tracked-cd, que leebinding.yml, trae el header debaldurk/renderdoc, regenera y publica solo si la API generada cambió. Con cron mensual, el mismo horario que los tres bindings XML.No hay inputs
xml-*: el origen sale del manifiesto, que ya declaraPrimera vez para dos cosas
Es el primer binding generado desde un header C que funciona así, y el primer uso real del adaptador
git-tree— hasta ahora solo se había ejecutadohttp-file, en los tres repos XML.Y es el primero que corre la acción de fetch en Windows, que hasta
v1.4.1habría fallado: la acción teníapython3hardcodeado, que en esos runners no existe.Qué debe pasar en el primer run
El header vendorizado y el upstream son byte-idénticos (36.480 b). Así que:
Publicar aquí sería un fallo, no un éxito. Es la prueba más barata posible del adaptador: un noop que cuesta una llamada HTTP.
Lo que se vigila especialmente es que no diga "cambió" teniendo bytes idénticos — sería el bucle de finales de línea que arregla
v1.4.1, y significaría regenerar y publicar cada mes sin motivo.🤖 Generated with Claude Code