Skip to content

Add refactoring change manager compatibility hook #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel-Darbord merged 3 commits into from
Jun 15, 2026
Merged

Add refactoring change manager compatibility hook #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc0daa9
Add refactoring change manager compatibility hook
Gabriel-Darbord Jun 15, 2026
775a373
Add Pharo 14 refactoring manager hook
Gabriel-Darbord Jun 15, 2026
e58df95
Add Pharo 12 refactoring manager hook
Gabriel-Darbord Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 59 additions & 51 deletions src/BaselineOfPharoCompatibility/BaselineOfPharoCompatibility.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,63 +13,71 @@ BaselineOfPharoCompatibility >> baseline: spec [

<baseline>
spec for: #common do: [
spec postLoadDoIt: #postload:package:.
spec
package: 'PharoCompatibility-Core';
package: 'PharoCompatibility-Tests'
with: [ spec requires: #( 'PharoCompatibility-Core' ) ];
group: 'default' with: #( 'PharoCompatibility-Core' );
group: 'Pharo12Surface' with: #( 'PharoCompatibility-Core' );
group: 'Pharo13Surface' with: #( 'PharoCompatibility-Core' );
group: 'Tests' with: #( 'PharoCompatibility-Tests' ) ].
spec postLoadDoIt: #postload:package:.
spec
package: 'PharoCompatibility-Core';
package: 'PharoCompatibility-Tests'
with: [ spec requires: #( 'PharoCompatibility-Core' ) ];
group: 'default' with: #( 'PharoCompatibility-Core' );
group: 'Pharo12Surface' with: #( 'PharoCompatibility-Core' );
group: 'Pharo13Surface' with: #( 'PharoCompatibility-Core' );
group: 'Tests' with: #( 'PharoCompatibility-Tests' ) ].

spec for: #'pharo12.x' do: [
spec
package: 'PharoCompatibility-Pharo13Surface-Pharo12'
with: [ spec requires: #( 'PharoCompatibility-Core' ) ];
package: 'PharoCompatibility-Pharo13Surface-Pharo12-Tests'
with: [
spec requires:
#( 'PharoCompatibility-Tests'
'PharoCompatibility-Pharo13Surface-Pharo12' ) ];
group: 'Pharo13Surface'
with: #( 'PharoCompatibility-Pharo13Surface-Pharo12' );
group: 'Tests'
with:
#( 'PharoCompatibility-Tests'
'PharoCompatibility-Pharo13Surface-Pharo12-Tests' ) ].
spec
package: 'PharoCompatibility-Pharo13Surface-Pharo12'
with: [ spec requires: #( 'PharoCompatibility-Core' ) ];
package: 'PharoCompatibility-Pharo13Surface-Pharo12-Tests'
with: [
spec requires:
#( 'PharoCompatibility-Tests' 'PharoCompatibility-Pharo13Surface-Pharo12' ) ];
group: 'Pharo13Surface'
with: #( 'PharoCompatibility-Pharo13Surface-Pharo12' );
group: 'Tests'
with:
#( 'PharoCompatibility-Tests' 'PharoCompatibility-Pharo13Surface-Pharo12-Tests' ) ].

spec for: #'pharo13.x' do: [
spec
package: 'PharoCompatibility-Pharo13Surface-Pharo13'
with: [ spec requires: #( 'PharoCompatibility-Core' ) ];
package: 'PharoCompatibility-Pharo13Surface-Pharo13-Tests'
with: [
spec requires:
#( 'PharoCompatibility-Tests' 'PharoCompatibility-Pharo13Surface-Pharo13' ) ];
group: 'Pharo13Surface'
with: #( 'PharoCompatibility-Pharo13Surface-Pharo13' );
group: 'Tests'
with:
#( 'PharoCompatibility-Tests' 'PharoCompatibility-Pharo13Surface-Pharo13-Tests' ) ].

spec for: #'pharo14.x' do: [
spec
package: 'PharoCompatibility-Pharo13Surface-Pharo14'
with: [ spec requires: #( 'PharoCompatibility-Core' ) ];
package: 'PharoCompatibility-Pharo13Surface-Pharo14-Tests'
with: [
spec requires:
#( 'PharoCompatibility-Tests'
'PharoCompatibility-Pharo13Surface-Pharo14' ) ];
group: 'Pharo13Surface'
with: #( 'PharoCompatibility-Pharo13Surface-Pharo14' );
group: 'Tests'
with:
#( 'PharoCompatibility-Tests'
'PharoCompatibility-Pharo13Surface-Pharo14-Tests' ) ].
spec
package: 'PharoCompatibility-Pharo13Surface-Pharo14'
with: [ spec requires: #( 'PharoCompatibility-Core' ) ];
package: 'PharoCompatibility-Pharo13Surface-Pharo14-Tests'
with: [
spec requires:
#( 'PharoCompatibility-Tests' 'PharoCompatibility-Pharo13Surface-Pharo14' ) ];
group: 'Pharo13Surface'
with: #( 'PharoCompatibility-Pharo13Surface-Pharo14' );
group: 'Tests'
with:
#( 'PharoCompatibility-Tests' 'PharoCompatibility-Pharo13Surface-Pharo14-Tests' ) ].

spec for: (self pharoVersionsFrom: 13) do: [
spec
package: 'PharoCompatibility-Pharo12Surface-Pharo13'
with: [ spec requires: #( 'PharoCompatibility-Core' ) ];
package: 'PharoCompatibility-Pharo12Surface-Pharo13-Tests'
with: [
spec requires:
#( 'PharoCompatibility-Tests'
'PharoCompatibility-Pharo12Surface-Pharo13' ) ];
group: 'Pharo12Surface'
with: #( 'PharoCompatibility-Pharo12Surface-Pharo13' );
group: 'Tests'
with:
#( 'PharoCompatibility-Tests'
'PharoCompatibility-Pharo12Surface-Pharo13-Tests' ) ]
spec
package: 'PharoCompatibility-Pharo12Surface-Pharo13'
with: [ spec requires: #( 'PharoCompatibility-Core' ) ];
package: 'PharoCompatibility-Pharo12Surface-Pharo13-Tests'
with: [
spec requires:
#( 'PharoCompatibility-Tests' 'PharoCompatibility-Pharo12Surface-Pharo13' ) ];
group: 'Pharo12Surface'
with: #( 'PharoCompatibility-Pharo12Surface-Pharo13' );
group: 'Tests'
with:
#( 'PharoCompatibility-Tests' 'PharoCompatibility-Pharo12Surface-Pharo13-Tests' ) ]
]

{ #category : 'actions' }
Expand Down
8 changes: 8 additions & 0 deletions ...mpatibility-Pharo13Surface-Pharo12-Tests/PharoCompatibilityP13SurfacePharo12Test.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,11 @@ PharoCompatibilityP13SurfacePharo12Test >> testInstallPharo13SurfaceProvidesMill

self assertPharo13SurfaceProvidesMillisecondSemaphoreTimeout
]

{ #category : 'tests' }
PharoCompatibilityP13SurfacePharo12Test >> testRefactoringChangeManagerClass [

self
assert: PharoCompatibility refactoringChangeManagerClass
equals: RBRefactoryChangeManager
]
7 changes: 7 additions & 0 deletions src/PharoCompatibility-Pharo13Surface-Pharo12/PharoCompatibility.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Extension { #name : 'PharoCompatibility' }

{ #category : '*PharoCompatibility-Pharo13Surface-Pharo12' }
PharoCompatibility class >> refactoringChangeManagerClass [

^ RBRefactoryChangeManager
]
18 changes: 18 additions & 0 deletions ...mpatibility-Pharo13Surface-Pharo13-Tests/PharoCompatibilityP13SurfacePharo13Test.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
"
Tests runtime-specific Pharo 13 compatibility surface behavior.
"
Class {
#name : 'PharoCompatibilityP13SurfacePharo13Test',
#superclass : 'PharoCompatibilityP13SurfaceTest',
#category : 'PharoCompatibility-Pharo13Surface-Pharo13-Tests-Tests',
#package : 'PharoCompatibility-Pharo13Surface-Pharo13-Tests',
#tag : 'Tests'
}

{ #category : 'tests' }
PharoCompatibilityP13SurfacePharo13Test >> testRefactoringChangeManagerClass [

self
assert: PharoCompatibility refactoringChangeManagerClass
equals: RBRefactoryChangeManager
]
1 change: 1 addition & 0 deletions src/PharoCompatibility-Pharo13Surface-Pharo13-Tests/package.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Package { #name : 'PharoCompatibility-Pharo13Surface-Pharo13-Tests' }
7 changes: 7 additions & 0 deletions src/PharoCompatibility-Pharo13Surface-Pharo13/PharoCompatibility.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Extension { #name : 'PharoCompatibility' }

{ #category : '*PharoCompatibility-Pharo13Surface-Pharo13' }
PharoCompatibility class >> refactoringChangeManagerClass [

^ RBRefactoryChangeManager
]
1 change: 1 addition & 0 deletions src/PharoCompatibility-Pharo13Surface-Pharo13/package.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Package { #name : 'PharoCompatibility-Pharo13Surface-Pharo13' }
6 changes: 6 additions & 0 deletions ...mpatibility-Pharo13Surface-Pharo14-Tests/PharoCompatibilityP13SurfacePharo14Test.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,12 @@ PharoCompatibilityP13SurfacePharo14Test >> testPharo13ContextTempNamesSelector [
self assert: (names includes: 'temporaryValue')
]

{ #category : 'tests' }
PharoCompatibilityP13SurfacePharo14Test >> testRefactoringChangeManagerClass [

self assert: PharoCompatibility refactoringChangeManagerClass equals: ReChangeManager
]

{ #category : 'tests' }
PharoCompatibilityP13SurfacePharo14Test >> testUndeclaredVariableNodeFromCompilationError [

Expand Down
7 changes: 7 additions & 0 deletions src/PharoCompatibility-Pharo13Surface-Pharo14/PharoCompatibility.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Extension { #name : 'PharoCompatibility' }

{ #category : '*PharoCompatibility-Pharo13Surface-Pharo14' }
PharoCompatibility class >> refactoringChangeManagerClass [

^ ReChangeManager
]
Loading