Audit reflective compatibility helpers against surface model#6
Merged
Conversation
Move compiler-error extraction out of core and into the Pharo 13 surface package for the Pharo 13 runtime. Keep Author lookup as an explicit global boundary while trusting the Author protocol directly. Co-authored-by: Codex <codex@openai.com>
Add direct Pharo 12 and Pharo 14 implementations for syntax and undeclared-variable extraction in their Pharo 13 surface packages. Cover the surface contracts without reflective probes. Co-authored-by: Codex <codex@openai.com>
Return class-name symbols from syntaxErrorNoticeClassName and update surface tests to pass class-name symbols where APIs accept them. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
respondsTo:/perform:/instVarNamed:helper logic with direct surface contractsAuthoras an explicit global boundary while trusting its protocol directlyVerification
PharoCompatibilityTest+PharoCompatibilityP13SurfacePharo12Testvia SUnit underAuthor useAuthor:=> 8 run, 8 passedPharoCompatibility-Tests,PharoCompatibility-Pharo12Surface-Pharo13-Tests,PharoCompatibility-Pharo13Surface-Pharo13-Tests=> 7 run, 7 passedPharoCompatibilityTest,PharoCompatibilityP13SurfacePharo14Test,PharoCompatibilityP12SurfacePharo13Test=> 13 run, 13 passedrespondsTo:,perform:, orinstVarNamed:matches insrcFixes #5