Skip to content

Cover compiler error notice compatibility #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel-Darbord merged 1 commit into from
Jun 27, 2026
Merged

Cover compiler error notice compatibility #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...mpatibility-Pharo13Surface-Pharo12-Tests/PharoCompatibilityP13SurfacePharo12Test.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,19 @@ PharoCompatibilityP13SurfacePharo12Test >> testSyntaxErrorNoticeClassName [
equals: #RBSyntaxErrorNotice
]

{ #category : 'tests' }
PharoCompatibilityP13SurfacePharo12Test >> testUndeclaredVariableNodeFromCompileWarning [

| node |
[ Object
compile: 'pharoCompatibilityBrokenMethod ^ missingCompatibilityVariable' ]
on: Exception
do: [ :error |
node := PharoCompatibility undeclaredVariableNodeFromException: error ].
self assert: node notNil.
self assert: node name equals: #missingCompatibilityVariable
]

{ #category : 'tests' }
PharoCompatibilityP13SurfacePharo12Test >> testWithNonInteractiveAuthorUsesAuthorWhenNoAuthorIsConfigured [

Expand Down
14 changes: 14 additions & 0 deletions ...mpatibility-Pharo13Surface-Pharo14-Tests/PharoCompatibilityP13SurfacePharo14Test.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,20 @@ PharoCompatibilityP13SurfacePharo14Test >> testSyntaxErrorNoticeClassName [
equals: #OCSyntaxErrorNotice
]

{ #category : 'tests' }
PharoCompatibilityP13SurfacePharo14Test >> testSyntaxNoticeFromCodeError [

| compiler notice |
compiler := SmalltalkImage current compiler.
compiler compilationContext isScripting: true.
[ compiler evaluate: '1 +' ]
on: Exception
do: [ :error |
notice := PharoCompatibility syntaxNoticeFromException: error ].
self assert: notice notNil.
self assert: notice class name equals: #OCSyntaxErrorNotice
]

{ #category : 'tests' }
PharoCompatibilityP13SurfacePharo14Test >> testUndeclaredVariableNodeFromCompilationError [

Expand Down
14 changes: 14 additions & 0 deletions src/PharoCompatibility-Pharo13Surface-Pharo14/OCCodeError.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Extension { #name : 'OCCodeError' }

{ #category : '*PharoCompatibility-Pharo13Surface-Pharo14' }
OCCodeError >> pharoCompatibilitySyntaxNotice [

^ self notice
]

{ #category : '*PharoCompatibility-Pharo13Surface-Pharo14' }
OCCodeError >> pharoCompatibilityUndeclaredVariableNode [

^ self notice ifNotNil: [ :syntaxNotice |
syntaxNotice pharoCompatibilityUndeclaredVariableNode ]
]
Loading