Skip to content

feat: Fake Role API#671

Draft
Someone-193 wants to merge 16 commits into
ExMod-Team:masterfrom
Someone-193:fake-role-API
Draft

feat: Fake Role API#671
Someone-193 wants to merge 16 commits into
ExMod-Team:masterfrom
Someone-193:fake-role-API

Conversation

@Someone-193
Copy link
Copy Markdown

Description

Describe the changes
Add API for faking roles, by viewer, by target. Still in progress

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

This reverts commit 2e7f2d3.
@Someone-193
Copy link
Copy Markdown
Author

AHHHHHHHHHHHH MERGING BRANCHES IS HARDDDDD

Everything seems to work but dummies are kinda schizo
@louis1706
Copy link
Copy Markdown

how is that going ?

@Someone-193
Copy link
Copy Markdown
Author

how is that going ?

still waiting on testers, I don't know any bugs that exist with this currently (I think I fixed them all)

@Someone-193 Someone-193 changed the base branch from dev to master April 3, 2026 14:28
@PUDGE133
Copy link
Copy Markdown

PUDGE133 commented Apr 3, 2026

What is this anyway? What can I use it for?

@louis1706
Copy link
Copy Markdown

What is this anyway? What can I use it for?

for faking the player role

@Someone-193 Someone-193 marked this pull request as ready for review April 16, 2026 23:28
Comment thread EXILED/Exiled.Events/Handlers/Internal/Round.cs Outdated
@Unbistrackted
Copy link
Copy Markdown

I spent 1 hoour doing the same on a private commission and didn't see this pr existed 😭
btw good feature

@Someone-193
Copy link
Copy Markdown
Author

I spent 1 hoour doing the same on a private commission and didn't see this pr existed 😭 btw good feature

cant you test it then 🥺

@github-actions github-actions Bot added Transpiler and removed Events labels May 9, 2026
@Someone-193 Someone-193 marked this pull request as draft May 9, 2026 22:29
@Someone-193
Copy link
Copy Markdown
Author

I made this a draft again because it 100% needs testing. I also left some logging in the last commit, they shouldn't ever spam, they should only run like once per role change. Lmk if there's any issues

@Unbistrackted
Copy link
Copy Markdown

Feels good to use it, and so far no issues when testing with my friends (outside of that thing I sent in the DM)

The only thing I woul add is a remark on Authority.AffectSelf, saying that it does not automatically change the appearece if you don't actually send it (cause my dumbass thought it would do so)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants