fix: respect CustomWeapon ClipSize and preserve ammo on drop (#817)

[intjiraya]

Description

Describe the changes

Fixes three defects in CustomWeapon that caused custom weapon configuration to be silently lost (issue #817).

What is the current behavior? (You can also link to an open issue here)

Closes #817.

• ClipSize larger than the stock magazine is silently truncated. firearm.MagazineAmmo = ClipSize writes to MagazineModule.SyncData but the base game still caps the magazine at AmmoMax = _defaultCapacity + attachmentMod in OnAdded, ServerLoadAmmoFromInventory, and OnAttachmentsApplied. Nothing in CustomWeapon raised _defaultCapacity, so reload / give / respawn truncate back to stock.
• After the player dies or escapes, the dropped pickup's ammo is reset to ClipSize. The drop path (CustomItem.OnInternalOwnerDying -> Spawn(Vector3, Item, Player?)) unconditionally wrote firearm.MagazineAmmo = ClipSize, discarding the player's actual round count.
• CustomWeapon.Spawn(Vector3, Player?) returns null for every firearm. The type guard introduced in fix: Item leaks #763 is inverted relative to its log message: if (Type.IsWeapon(false)) returns null when the type IS a firearm.

What is the new behavior? (if this is a feature change)

• Lift Firearm.MaxMagazineAmmo (which writes _defaultCapacity) to ClipSize in Spawn, Spawn(Item), Give, and OnInternalReloaded so the custom value survives every base-game clamp.
• Drop the MagazineAmmo = ClipSize write in Spawn(Vector3, Item, Player?) so the dropped pickup preserves whatever ammo the player actually had on death/escape. Initial-fill semantics stay in the no-Item overload and in Give.
• Negate the firearm-type guard in Spawn(Vector3, Player?) so it matches its log message and the method actually runs for firearms.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No.

Other information:

N/A.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentations

Submission checklist

• I have checked the project can be compiled
• I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

• I have checked no IL patching errors in the console

Other

• Still requires more testing

[intjiraya]

@microsievert

[Someone-193]

The IsWeapon check was added in #763 by MS

[MS-crew]

The IsWeapon check was added in #763 by MS

:(

[intjiraya]

I’ll build it tomorrow, check for possible errors, verify that the changes are correct, and make the PR ready for review 🤓

[intjiraya]

fahhh

[Copilot]

Pull request overview

This PR fixes CustomWeapon firearm spawning/giving/reloading so custom ClipSize is respected by the underlying firearm magazine cap, and so dropped weapons preserve the actual remaining ammo (issue #817).

Changes:

• Fixes an inverted firearm-type guard in CustomWeapon.Spawn(Vector3, Player?) so firearms are actually spawned.
• Raises the firearm magazine maximum to ClipSize across spawn/give/reload flows to prevent base-game clamping back to default capacity.
• Preserves actual magazine ammo when spawning a pickup from an existing firearm item (death/escape drops) by removing the unconditional refill to ClipSize.

[louis1706]

Pull request overview

This PR fixes CustomWeapon firearm spawning/giving/reloading so custom ClipSize is respected by the underlying firearm magazine cap, and so dropped weapons preserve the actual remaining ammo (issue #817).

Changes:

• Fixes an inverted firearm-type guard in CustomWeapon.Spawn(Vector3, Player?) so firearms are actually spawned.
• Raises the firearm magazine maximum to ClipSize across spawn/give/reload flows to prevent base-game clamping back to default capacity.
• Preserves actual magazine ammo when spawning a pickup from an existing firearm item (death/escape drops) by removing the unconditional refill to ClipSize.

Bro i disabled you in setting why are you there

[louis1706]

Other than this comment i will approved it (i will approve it if there a good reason would still try to found to make it work without setting it at every reload)