fix: read the OS-assigned port back from the listener in becomeCoordinator - #43
Merged
Conversation
…nator becomeCoordinator stored the port parameter it was called with instead of reading server.address() the way addListener already does. This only matters when called with port 0 for an OS-assigned free port: the listener's actual bound port was silently discarded and listListeners() reported 0 instead of the real port, breaking anything that reads the listener list to find where to connect. Applies to both TlsTransport and TcpTransport; WsTransport has no equivalent listener-list bookkeeping to be affected.
…bind
Calls becomeCoordinator("127.0.0.1", 0) directly on both TlsTransport and
TcpTransport, then asserts listListeners() reports a non-zero port and
that a real connection to that reported port succeeds.
Mearman
marked this pull request as ready for review
September 9, 2026 22:30
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.27.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
becomeCoordinator stored the port parameter it was called with instead of reading server.address() the way addListener already does. This only matters when called with port 0 for an OS-assigned free port: the listener's actual bound port was silently discarded and listListeners() reported 0 instead of the real port.
Applied to both TlsTransport and TcpTransport. WsTransport has no equivalent coordinator listener-list bookkeeping (its dataPort tracking is a separate, unrelated data server that already reads server.address() correctly), so it needed no change.
Added a dedicated regression test that calls becomeCoordinator("127.0.0.1", 0) directly on both transports and asserts listListeners() reports the real bound port, with a live connection to that port to prove it. Confirmed the test fails against the pre-fix code before restoring the fix.