Repository navigation
fix(headroom): cap and rotate the daemon log - #616
Merged
Merged
Conversation
The daemon log was appended to for the life of the supervisor and never trimmed, so a long-running daemon grew it without bound. The supervisor now checks the log at the top of every tick and, once it passes a size cap, copies it to a numbered generation and empties it in place, keeping a fixed number of earlier copies. It is emptied rather than renamed because the daemon holds an appending descriptor on the file. Rotation runs before a start attempt takes its log offset, so an early-exit report still reads only that attempt's own output. Fixes #615
Member
Author
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #615.
The supervisor now rotates the headroom daemon log. At the top of every tick it checks the file's size and, once it passes
HEADROOM_LOG_MAX_BYTES, copies it toheadroom.log.1and empties it in place, first shifting the earlier copies one place older and deleting the one pastHEADROOM_LOG_KEPT_GENERATIONS. The live file and its kept copies therefore stay bounded however long the daemon runs.The file is emptied rather than renamed away because the daemon holds a descriptor on it opened for appending, and a renamed file would keep receiving its output. Lines written between the copy and the emptying are lost, which is the cost of rotating a file whose writer cannot reopen it.
Rotation runs before a start attempt takes its log offset, so the early-exit report in
lastErrorstill reads only that attempt's own output. The rotation itself is a small shared helper over the farm filesystem port (src/logRotation.ts).Tests:
logRotation.test.tscovers the helper against a fake filesystem and against a real file that a descriptor opened for appending keeps writing to across a rotation.supervisorLog.test.tscovers the supervisor asking for rotation each tick, a rotation leaving the daemon running, and an early-exit report staying correct after a rotation between attempts. The supervisor tests fail with the rotation call removed.