Repository navigation
fix: stop two tests depending on how fast a busy machine runs - #620
Merged
Merged
Conversation
The watchdog tests that wait for a sampler's own outcome gave it the production deadline, so a child process that was slow to start made the watchdog report that the sampler did not finish instead of how it ended. They now use the file's existing guard against a sampler that never ends. The activity width sweep resolved the statusline settings and rebuilt the palette for every row at every width of every session. The settings and palette are now built once per case and the render context once per session and width, shared by the five rows. Fixes #618
Mearman
marked this pull request as ready for review
October 27, 2026 18:09
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #618.
watchdog.test.ts: the sampler tests that wait for the sampler's own outcome passed the production deadline asoverheadMs, so a child process slow to start made the watchdog log that the sampler did not finish, and the assertion on how it ended failed. They now usePAUSE_WAIT_GUARD_MS, the guard the file already uses for waits that are not an expectation of how long something takes. The tests of the deadline itself keep their own. The deadline was already a parameter, so no change to the watchdog is needed.I reproduced the failure by delaying the failing child past the old deadline: with the production deadline the test fails with "did not finish within 3000ms", with the guard it passes. The delay was not committed.
activityFit.test.ts: the sweep calledresolveStatusline(a schema parse) andcreatePaletteinside the innermost loop, once per row. It now builds them once per case and the render context once per session and width, shared by the five rows. Per case that is 1 settings resolution instead of 7260 and 1452 contexts instead of 7260, over the same sessions, widths and rows, so the same lines are checked.