feat: add a prepare script so a git-dependency install builds itself - #5
Merged
Conversation
An npm-published install gets dist/ pre-built into the tarball, but a git dependency (github:ExaDev/cddl.js#main) gets a plain checkout with no dist/ at all -- every subpath export failed to resolve. prepare is the standard npm/pnpm lifecycle hook for exactly this: it runs after a git-ref install, before the dependent's own install finishes.
Mearman
marked this pull request as ready for review
September 10, 2026 09:07
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while wiring wire-mesh's ts/packages/core to consume cddl.js as a git dependency (github:ExaDev/cddl.js#main, since it isn't published to npm): an npm-published install gets dist/ pre-built into the tarball, but a git-ref install is a plain source checkout with no dist/ at all, so every subpath export (./emitter, ./runtime, ./parse) failed to resolve.
prepare is the standard npm/pnpm lifecycle hook for exactly this case -- it runs after a git-ref install, before the dependent's own install finishes. Verified:
rm -rf dist vendor/cddl/dist && pnpm run preparerebuilds both from a clean checkout.