fix: build config stays plain JS, not TS - #7
Merged
Conversation
The prepare script (pnpm run build) failed installing as a git dependency in CI: Node's native TS-stripping refuses to process a .ts file located under node_modules, and a git-dependency install always resolves into exactly such a path while its prepare script runs. tsdown.config.ts needed no TS syntax at all, so it stays tsdown.config.js instead of fighting the restriction with a --config-loader flag. Verified against the actual failure mode, not just locally: copied the package into a node_modules-nested path and ran the build from there.
Mearman
marked this pull request as ready for review
September 10, 2026 09:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Mearman
added a commit
to ExaDev/wire-mesh
that referenced
this pull request
Sep 10, 2026
CI failed installing cddl.js as a git dependency: its prepare script couldn't load tsdown.config.ts, since Node's native TS-stripping refuses to process a .ts file under node_modules -- exactly where a git-dependency install resolves into while prepare runs. Fixed upstream (ExaDev/cddl.js#7, tsdown.config.ts -> tsdown.config.js); this repins the lockfile to pick it up.
Mearman
added a commit
to ExaDev/wire-mesh
that referenced
this pull request
Sep 10, 2026
CI failed installing cddl.js as a git dependency: its prepare script couldn't load tsdown.config.ts, since Node's native TS-stripping refuses to process a .ts file under node_modules -- exactly where a git-dependency install resolves into while prepare runs. Fixed upstream (ExaDev/cddl.js#7, tsdown.config.ts -> tsdown.config.js); this repins the lockfile to pick it up.
Mearman
added a commit
to ExaDev/wire-mesh
that referenced
this pull request
Sep 10, 2026
CI failed installing cddl.js as a git dependency: its prepare script couldn't load tsdown.config.ts, since Node's native TS-stripping refuses to process a .ts file under node_modules -- exactly where a git-dependency install resolves into while prepare runs. Fixed upstream (ExaDev/cddl.js#7, tsdown.config.ts -> tsdown.config.js); this repins the lockfile to pick it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire-mesh's ts/packages/core CI job failed installing cddl.js as a git dependency: Node's native TS-stripping refuses to process a
.tsfile located undernode_modules, and a git-dependency install always resolves into exactly such a path while itspreparescript (pnpm run build) runs -- tsdown couldn't even loadtsdown.config.ts.The config file needed no TS syntax at all, so it stays
tsdown.config.jsinstead of fighting the restriction with a--config-loaderflag (the error message's own suggested workaround).Verified against the actual failure mode, not just locally: copied the package into a path nested under
node_modulesand ran the build from there.