ci: fail an npm-alias publish leg whose trusted publisher is not registered - #1195
Merged
Conversation
Mearman
marked this pull request as ready for review
September 10, 2026 07:07
Member
Author
|
@codex security review |
Mearman
enabled auto-merge (rebase)
September 10, 2026 07:07
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
… registered The unregistered-trusted-publisher signatures (the OIDC exchange 404 and the bare PUT 404 on the unregistered name) skipped with a notice instead of failing the leg, which made the one-time registration permanently invisible: every alias stayed stranded from the monorepo migration until a manual audit found them. The leg now fails carrying the same registration instructions as an error annotation. Nothing downstream depends on the post-release jobs, so the release and the Pages deploy still cannot be blocked -- the red is a signal, not a gate. The GitHub Packages mirror keeps its graceful skip.
Mearman
force-pushed
the
fix/ci-alias-unregistered-fails
branch
from
September 10, 2026 07:20
69b6b7e to
4f408db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unregistered-trusted-publisher signatures (the OIDC exchange 404, the bare PUT 404 on the unregistered name) skipped with a notice instead of failing the leg, which made the one-time registration permanently invisible -- every alias stayed stranded from the monorepo migration until a manual audit found them. The leg now fails carrying the same registration instructions as an error annotation.
The failure is a signal, not a gate: nothing depends on the post-release jobs, so the release and the Pages deploy still cannot be blocked -- the red names the outstanding registration the moment a release runs. The GitHub Packages mirror keeps its graceful skip (a different mechanism, separately tracked).