documents.js: write tracked-change regions and ODF index wrappers; embed objects in odf shapes - #1200
Merged
Merged
Conversation
readDrawFrameContent gains the draw:object branch (checked first, ahead of every other content, for the identical ObjectReplacements-preview reason the odt and ods readers already order it that way), opted into per format so ods's own cell-anchored resolution keeps its shape; the shape writer admits a lone embedded-object block through the identical writeEmbeddedObject machinery an odt body embedding uses, refusing one found alongside other content by name. The root barrel now exports odfIndexWrapperTag and writeOdfIndexWrapper so documents.js's odt editor can open real index-wrapper regions (the follow-up commit).
… the builders The docx builder's marker walk opens a provenance pair as a real w:ins/w:del/w:moveFrom/w:moveTo region -- author and date riding the element, deletion interiors re-spelling their runs' text w:delText on close, Word's own spelling -- the exact inverse ooxml.js's reader recovers; formatChange stays dropped by name (property-layer spellings, no block-level element). The odt builder opens an index contentControl pair as a real wrapper region (text:table-of-content or the sibling the descriptor's *-source residue names) whose cached blocks land inside its own text:index-body, mirroring odf.js's writeOdfIndexWrapper; a residue-less index descriptor stays dropped (nothing names which of the seven wrappers to write).
Mearman
marked this pull request as ready for review
September 10, 2026 13:15
Member
Author
|
@codex security review |
Mearman
enabled auto-merge (rebase)
September 10, 2026 13:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
🎉 This PR is included in version 7.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1190 -- all three items:
Every implemented region round-trips through the corresponding reader's real bytes. The construct-marker README passage now states every body-scope wrapper kind survives both builders, with the two named refusals.
Closes #1190.