Repository navigation
docs(autoscaler): say why a runner pod's CPU request was not halved - #126
Merged
Merged
Conversation
The ceiling is the tighter of CPU and memory per node, so a smaller CPU request raises it only where CPU decides. Records the measured case where halving it bought one runner against throttling every multi-core job, and when to revisit it.
Mearman
marked this pull request as ready for review
October 20, 2026 21:45
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
|
🎉 This PR is included in version 2.7.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records in the Autoscaler section that halving a 2 CPU, 7Gi runner pod to 1 CPU was measured and not taken: with the ceiling worked out per node (#121), memory then decided on both nodes of the pool it was measured on, so it bought one runner (5 to 6) against throttling every job that keeps more than one core busy, with no CPU history to weigh that by. Revisit triggers: CPU history exists, one more runner is worth the throttling, or a node with too few cores for the larger pod needs a 1 CPU pod to take work.