Disable KeyboardAvoidingView while currency picker is open on amount step by MelvinBot · Pull Request #89133 · Expensify/App

MelvinBot · 2026-04-28T20:28:10Z

Explanation of Change

On native (iOS/Android), the money request amount screen uses a custom BigNumberPad instead of the system keyboard. When the user opens the currency picker and focuses its search field, the system keyboard appears. The parent KeyboardAvoidingView (enabled by default in StepScreenWrapper) reacts to this global keyboard event and pushes the numpad upward. When the picker is dismissed, the numpad snaps back down, causing a visible jump.

This PR disables the KeyboardAvoidingView entirely on the amount step by passing shouldEnableKeyboardAvoidingView={false} to StepScreenWrapper. On touchable devices the custom keypad is shown (no system keyboard), and on non-touchable devices the input is always shown above the keyboard — so keyboard avoidance is unnecessary on this page.

Fixed Issues

$ #88913

Tests

Open the app on a native device (iOS or Android)
Start creating a money request (Request money or Split bill)
On the amount step, tap the currency button to open the currency picker
Search for a currency in the picker, then select one or dismiss the picker
Verify the numpad does not jump or shift when the currency picker opens/closes
Verify no errors appear in the JS console

Offline tests

N/A — this change only affects keyboard avoidance layout behavior, no network dependency.

QA Steps

Open the app on a native device (iOS or Android)
Start creating a money request (Request money or Split bill)
On the amount step, tap the currency button to open the currency picker
Search for a currency in the picker, then select one or dismiss the picker
Verify the numpad does not jump or shift when the currency picker opens/closes
Repeat on mWeb (Chrome on Android, Safari on iOS) and desktop web
Verify no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

…step On native, the amount screen uses BigNumberPad (not the system keyboard), but its parent KeyboardAvoidingView still reacts to the global keyboard event from the currency picker's search field, causing the numpad to jump. Gating the prop on isCurrencyPickerVisible disables avoidance only while the picker is open — when the picker closes the keyboard is already gone, so re-enabling avoidance is safe. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

aimane-chnaif · 2026-04-28T20:36:54Z

            shouldShowWrapper={!!backTo || isEditing}
            includeSafeAreaPaddingBottom
            shouldShowNotFoundPage={shouldShowNotFoundPage}
+            shouldEnableKeyboardAvoidingView={!isCurrencyPickerVisible}


@MelvinBot no need to avoid keyboard at all on this page.
On touchable devices, custom keypad is shown. On non-touchable devices, there's no virtual keyboard popup.

Suggested change

shouldEnableKeyboardAvoidingView={!isCurrencyPickerVisible}

shouldEnableKeyboardAvoidingView={false}

Applied! Set shouldEnableKeyboardAvoidingView={false} unconditionally since the custom keypad handles touchable devices and non-touchable devices keep input above the keyboard.

…t step Co-authored-by: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"} <{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}@users.noreply.github.com>

MelvinBot · 2026-04-28T20:44:47Z

🤖 Code Review — PR #89133

Change: Adds shouldEnableKeyboardAvoidingView={false} to StepScreenWrapper in IOURequestStepAmount.tsx:472.

Verdict: The change looks correct and safe.

Touch devices: BigNumberPad replaces the system keyboard (system keyboard is suppressed via disableKeyboard=true in NumberWithSymbolForm.tsx:168), so KeyboardAvoidingView has nothing to avoid — disabling it eliminates the spurious jump caused by the currency picker modal triggering keyboard appearance/disappearance events.
Desktop/web: No virtual keyboard exists, so disabling KeyboardAvoidingView is a no-op.
Established pattern: 29+ other screens already pass shouldEnableKeyboardAvoidingView={false}, including closely related ones like IOURequestStartPage.tsx and IOURequestStepCategory.tsx.

No regressions expected. 👍

codecov · 2026-04-28T20:47:51Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...rc/pages/iou/request/step/IOURequestStepAmount.tsx	`65.00% <ø> (ø)`
... and 17 files with indirect coverage changes

chatgpt-codex-connector · 2026-04-28T20:49:25Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aimane-chnaif · 2026-04-28T20:53:07Z

There's a tiny jump on mobile web but I don't think this is blocker as this doesn't look bad and the bug was reported in native platforms.
And no straightforward solution to fix this.

mchrome.mov

msafari.mov

aimane-chnaif · 2026-04-28T21:23:28Z

@MelvinBot add Tests / QA Steps and complete author checklist with below:

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MelvinBot · 2026-04-28T21:25:17Z

Updated the PR body:

Added Tests and QA Steps describing the currency picker flow to verify
Updated the explanation to reflect the current change (shouldEnableKeyboardAvoidingView={false} always)
Completed the relevant author checklist items
Added the provided screenshots/videos for all platforms

aimane-chnaif · 2026-04-28T21:26:47Z

@MelvinBot feel free to check off all unchecked items in checklist even though they're not related. I verified them manually.

MelvinBot · 2026-04-28T21:28:21Z

Checked off all remaining checklist items as requested.

aimane-chnaif · 2026-04-28T21:28:37Z

@MelvinBot mark as ready for review

MelvinBot · 2026-04-28T21:29:58Z

Marked as ready for review! ✅

melvin-bot · 2026-04-28T21:30:00Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2026-04-28T21:30:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

aimane-chnaif · 2026-04-28T21:31:10Z

@mountiny please generate adhoc build and verify fix on your iPhone

MelvinBot assigned aimane-chnaif Apr 28, 2026

MelvinBot requested a review from a team April 28, 2026 20:28

MelvinBot mentioned this pull request Apr 28, 2026

[$250] Native: keep custom amount numpad fixed when currency search shows system keyboard #88913

Open

aimane-chnaif reviewed Apr 28, 2026

View reviewed changes

MelvinBot marked this pull request as ready for review April 28, 2026 21:29

MelvinBot requested a review from a team as a code owner April 28, 2026 21:29

melvin-bot Bot requested review from JmillsExpensify and aimane-chnaif and removed request for a team April 28, 2026 21:29

melvin-bot Bot removed the request for review from a team April 28, 2026 21:30

aimane-chnaif approved these changes Apr 28, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny April 28, 2026 21:30

	shouldEnableKeyboardAvoidingView={!isCurrencyPickerVisible}
	shouldEnableKeyboardAvoidingView={false}

Conversation

MelvinBot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

codecov Bot commented Apr 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot commented Apr 28, 2026

Uh oh!

aimane-chnaif commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimane-chnaif commented Apr 28, 2026

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

aimane-chnaif commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

aimane-chnaif commented Apr 28, 2026

Uh oh!

MelvinBot commented Apr 28, 2026

Uh oh!

melvin-bot Bot commented Apr 28, 2026

Uh oh!

aimane-chnaif commented Apr 28, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MelvinBot commented Apr 28, 2026 •

edited

Loading

aimane-chnaif Apr 28, 2026 •

edited

Loading

codecov Bot commented Apr 28, 2026 •

edited by github-actions Bot

Loading

aimane-chnaif commented Apr 28, 2026 •

edited

Loading