Repository navigation
Fix push tokenization promise never settling in onActivityResult - #70
Merged
Merged
Conversation
MegaManSec
force-pushed
the
pr/jr-3-a330c1e
branch
from
February 16, 2026 18:52
5250548 to
c5820a2
Compare
… promise is not cleared (cherry picked from commit a330c1ee2261f192103ac4e7a2fa5d86e2c59b7f)
MegaManSec
force-pushed
the
pr/jr-3-a330c1e
branch
from
February 16, 2026 18:56
c5820a2 to
26e0ebf
Compare
Member
|
@MegaManSec may you resolve conflicts with main please? |
Contributor
Author
|
@JakubKorytko done |
JakubKorytko
reviewed
Oct 8, 2026
JakubKorytko
left a comment
JakubKorytko
left a comment
Member
There was a problem hiding this comment.
Tested on an emulator by calling onActivityResult directly with a fake promise:
RESULT_OK+ null data: rejects (hangs on main)- unknown
resultCode: rejects (hangs on main) RESULT_CANCELED: resolvesCANCELED, same as main
MegaManSec
changed the title
JakubKorytko
approved these changes
Oct 9, 2026
JakubKorytko
left a comment
JakubKorytko
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates, all three points are covered. Re-tested, LGTM
Member
|
thanks |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onActivityResultfor push tokenization never settled the promise whenresultCodewasRESULT_OKwith nulldata, or anything other thanRESULT_OK/RESULT_CANCELED, soaddCardToGoogleWallet/resumeAddCardToGoogleWallethung forever.RESULT_OKresolvesSUCCESSregardless ofdata;tokenIdis null when missing instead of the string"null".ERROR.