Fixes and Code Improvements - #614
Merged
Merged
Conversation
- Fixed issue where setting the email format to "Plain Text" in the SSH CLI menu, the WebUI would show the selection box as empty instead of reflecting the "Plain Text" setting made previously by the user. - Fixed parsing issues when handling unusual but valid user input for the "Secondary Email Address" option. - Improved functions that set and get configuration settings, also making sure values stored as assignment statements are defined as literal strings (e.g. KeyName='KeyValue'). - Included fix in the WebUI from @maghuro to properly handle the colon separator in login credentials (i.e. username:password). - Miscellaneous code improvements.
ExtremeFiretop
approved these changes
Sep 25, 2026
Owner
|
All good here! Thanks! Merging! |
Owner
|
Nice catch on the email format bug btw! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where, after setting the email format to "Plain Text" in the SSH CLI menu, the WebUI would show the selection box as empty instead of reflecting the "Plain Text" setting previously made by the user.
Fixed parsing issues when handling unusual but valid user input for the "Secondary Email Address" option.
Improved functions that set and get configuration settings, also making sure values stored as assignment statements are defined as literal strings (e.g. KeyName='KeyValue').
Included a fix in the WebUI from @maghuro to properly handle the colon separator in login credentials (i.e. "username:password") [Thanks @maghuro]
Miscellaneous code improvements.
Example screenshot showing the "Plain Text" issue: