Add nomad-file-parser dependency and migrate imports#178
Open
ndaelman-hu wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
@ladinesa you need make the repo public for the CI/CD to install the dependency |
Update all imports to use the new nomad-file-parser package: - nomad.parsing.file_parser → nomad_file_parser - nomad.parsing.file_parser.mapping_parser → nomad_file_parser.mapping_parser - nomad.parsing.file_parser.text_parser → nomad_file_parser.text_parser - nomad.parsing.file_parser.xml_parser → nomad_file_parser.xml_parser Affects 46 files across all parsers and schema packages.
ladinesa
force-pushed
the
feature/add-nomad-file-parser-dependency
branch
from
d611adb to
2f4dc06
Compare
Collaborator
|
@ndaelman-hu please fix the test then merge. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Migrate file parsing utilities from nomad-lab to the new nomad-file-parser package to decouple parser infrastructure from core NOMAD.
Scope
Included
nomad-file-parseras dependency (tracking develop branch)nomad.parsing.file_parser→nomad_file_parsernomad.parsing.file_parser.mapping_parser→nomad_file_parser.mapping_parsernomad.parsing.file_parser.text_parser→nomad_file_parser.text_parsernomad.parsing.file_parser.xml_parser→nomad_file_parser.xml_parserOut of scope
Context & Links
Reviewer Notes
This is a pure refactoring - all tests pass with the new imports. The nomad-file-parser package contains the same file parsing utilities that were previously in nomad-lab.
Status
Breaking Changes
Testing / Validation