Keep CSV logs in Documents/SecureDroneID when the directory exists - #8
Open
erkki wants to merge 1 commit into
Open
Keep CSV logs in Documents/SecureDroneID when the directory exists#8erkki wants to merge 1 commit into
erkki wants to merge 1 commit into
Conversation
getLoggerFileDir treated a false return from File.mkdirs() as failure, but mkdirs() also returns false when the directory already exists. Every run after the first therefore logged to getExternalFilesDir(), which is not browsable by file managers or adb on Android 11+. Fall back only when the directory neither was created nor exists. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getLoggerFileDirtreated a false return fromFile.mkdirs()as failure, butmkdirs()also returns false when the directory already exists. Every run after thefirst therefore logged to
getExternalFilesDir(), which is not browsable by filemanagers or adb on Android 11+. Fall back only when the directory neither was created
nor exists.