chore(deps): combined frontend dependency bumps (supersedes #757-#761) - #766
Merged
Merged
Conversation
Combines the open Dependabot pull requests for /app into a single change: - lucide-react 1.31.0 -> 1.45.0 (#761) - @radix-ui/react-slider 1.3.6 -> 1.4.7 (#760) - eslint-plugin-react-refresh 0.4.26 -> 0.5.6 (#759) - globals 17.11.0 -> 17.12.0 (#758) - eslint 10.8.1 -> 10.10.0 (#757) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dependency ReviewThe following issues were found:
OpenSSF ScorecardScorecard details
Scanned Files
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change updates five dependency version ranges in ChangesFrontend dependency updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to No concrete current-head risk is established for these dependency updates, so the change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The root package.json depends on the app workspace via file:app, so the root lockfile must be regenerated whenever app/package.json changes. Dependabot only updates app/package-lock.json, which caused 'npm ci' at the repository root to fail in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Regenerate the root package-lock.json to match the updated file:app dependency graph.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR consolidates five frontend dependency updates and refreshes the app lockfile.
Changes:
- Updates Radix Slider, Lucide React, ESLint, React Refresh, and globals.
- Regenerates
app/package-lock.jsonwith updated dependency resolutions.
File summaries
| File | Summary |
|---|---|
app/package.json |
Updates frontend dependency ranges. |
app/package-lock.json |
Records updated dependencies and transitive packages. |
Review details
Files not reviewed (1)
- app/package-lock.json: Generated file
- Files reviewed: 1/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are consistent and no unresolved issues were identified.
Review details
Files not reviewed (1)
- app/package-lock.json: Generated file
- Files reviewed: 1/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combines all five open Dependabot pull requests for
/appinto a single, fully-green PR.lucide-react@radix-ui/react-slidereslint-plugin-react-refresh(dev)globals(dev)eslint(dev)Why the individual Dependabot PRs are red
The root
package.jsondepends on the frontend via"queryweaver-app": "file:app", so the rootpackage-lock.jsoninlines the app's dependency tree. Dependabot only updatesapp/package-lock.json, which leaves the root lockfile out of sync and makes thenpm cistep intests.ymlfail with:This PR regenerates both lockfiles so the whole install graph is consistent, which also avoids the repeated lockfile conflicts that occur when merging these PRs one at a time.
Changes
app/package.json— the five version bumpsapp/package-lock.json— regeneratedpackage-lock.json(root) — regenerated to stay in sync with thefile:appdependencyValidation
Ran the exact CI install sequence from
tests.ymllocally, plus lint and build:npm ci(root) — passescd app && npm ci— passesnpm run lint(ESLint 10.10.0) — passes, no errorsnpm run build(Vite production build) — passes, 3737 modules transformedThe two major bumps (
lucide-react,@radix-ui/react-slider) were additionally type-checked withtsc -b; no new type errors. A pre-existingTS5101: 'baseUrl' is deprecateddiagnostic intsconfig.app.jsonalso reproduces onstagingand is unrelated to this change.All CI checks pass:
test,unit-tests,sdk-tests,build,spellcheck,dependency-review, and CodeQL.Follow-up
Once this merges, #757, #758, #759, #760 and #761 can be closed as superseded.