Skip to content

Neoforge 1.21.1 stabilization#1089

Closed
Mafsolin wants to merge 3 commits into
FallingColors:1.21from
Mafsolin:neoforge-1.21.1-stabilization
Closed

Neoforge 1.21.1 stabilization#1089
Mafsolin wants to merge 3 commits into
FallingColors:1.21from
Mafsolin:neoforge-1.21.1-stabilization

Conversation

@Mafsolin
Copy link
Copy Markdown

@Mafsolin Mafsolin commented Jun 4, 2026

Summary
I put this together mainly for myself so I could get Hex Casting building again on NeoForge 1.21.1, but it may be useful for others too.

I used an AI coding agent for a large part of the migration/stabilization work, then verified the results locally and iterated on the build until it produced a working jar.

Verified

  • :Neoforge:compileJava
  • :Neoforge:processResources
  • :Neoforge:build

Result
Build now produces a NeoForge 1.21.1 0.12.0-devel jar.

@object-Object
Copy link
Copy Markdown
Member

object-Object commented Jun 4, 2026

Our existing build already runs on NeoForge and is producing artifacts at https://ci.blamejared.com/job/petrakat/job/Hexcasting/job/1.21/. What changes does this PR actually make? It seems like just a lot of unnecessary permutations of Gradle.

@object-Object
Copy link
Copy Markdown
Member

After looking through the changes, it doesn't really seem like there's anything of substance here. As noted above, the existing code on our 1.21 branch already builds fine and produces public artifacts that you can directly download, so I'm not sure why this was necessary in the first place. We won't be merging this, and I'd advise others against trying to use it, especially since the scripts you've added are hardcoded to paths on your specific Windows machine.

@github-project-automation github-project-automation Bot moved this from 📋 Backlog to ✅ Done in Hex Casting Jun 4, 2026
@Mafsolin
Copy link
Copy Markdown
Author

Mafsolin commented Jun 4, 2026

You're right, I didn't notice that the existing 1.21 branch was already producing NeoForge artifacts in CI.

I started from local build/bootstrap issues on my side and overestimated how much of that was an upstream problem, so this PR ended up being much more about getting things reproducible in my environment than about fixing a missing upstream build target.

Sorry about the noise. I'm happy to close this PR, unless there are any small code-level pieces here that would be worth splitting out separately.

@Mafsolin Mafsolin deleted the neoforge-1.21.1-stabilization branch June 4, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants