-
Notifications
You must be signed in to change notification settings - Fork 11
Improve how thread priority is applied #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TrentHouliston
wants to merge
3
commits into
main
Choose a base branch
from
houliston/priority-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| /* | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2024 NUClear Contributors | ||
| * | ||
| * This file is part of the NUClear codebase. | ||
| * See https://github.com/Fastcode/NUClear for further info. | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated | ||
| * documentation files (the "Software"), to deal in the Software without restriction, including without limitation the | ||
| * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to | ||
| * permit persons to whom the Software is furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all copies or substantial portions of the | ||
| * Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE | ||
| * WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR | ||
| * COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| */ | ||
|
|
||
| #ifndef NUCLEAR_PRIORITY_LEVEL_HPP | ||
| #define NUCLEAR_PRIORITY_LEVEL_HPP | ||
|
|
||
| #include <cstdint> | ||
| #include <ostream> | ||
| #include <string> | ||
|
|
||
| namespace NUClear { | ||
|
|
||
| class PriorityLevel { | ||
| public: | ||
| enum Value : uint8_t { | ||
| UNKNOWN = 0, | ||
| IDLE = 1, | ||
| LOWEST = 2, | ||
| LOW = 3, | ||
| NORMAL = 4, | ||
| HIGH = 5, | ||
| HIGHEST = 6, | ||
| REALTIME = 7 | ||
| }; | ||
|
|
||
| /** | ||
| * Construct a PriorityLevel from a Value | ||
| * | ||
| * @param value The value to construct the PriorityLevel from | ||
| */ | ||
| constexpr PriorityLevel(const Value& value = Value::NORMAL) noexcept : value(value) {} | ||
|
|
||
| /** | ||
| * Construct a PriorityLevel from a string | ||
| * | ||
| * @param level The string to construct the PriorityLevel from | ||
| */ | ||
| PriorityLevel(const std::string& level) | ||
| : value(level == "IDLE" ? Value::IDLE | ||
| : level == "LOWEST" ? Value::LOWEST | ||
| : level == "LOW" ? Value::LOW | ||
| : level == "NORMAL" ? Value::NORMAL | ||
| : level == "HIGH" ? Value::HIGH | ||
| : level == "HIGHEST" ? Value::HIGHEST | ||
| : level == "REALTIME" ? Value::REALTIME | ||
| : Value::NORMAL) {} | ||
|
|
||
| /** | ||
| * A call operator which will return the value of the PriorityLevel | ||
| * This can be useful in situations where the implicit conversion operators are ambiguous. | ||
| * | ||
| * @return The value of the PriorityLevel | ||
| */ | ||
| constexpr Value operator()() const { | ||
| return value; | ||
| } | ||
|
|
||
| /** | ||
| * A conversion operator which will return the value of the PriorityLevel | ||
| * | ||
| * @return The value of the PriorityLevel | ||
| */ | ||
| constexpr operator Value() const { | ||
| return value; | ||
| } | ||
|
|
||
| /** | ||
| * A conversion operator which will return the string representation of the PriorityLevel | ||
| * | ||
| * @return The string representation of the PriorityLevel | ||
| */ | ||
| operator std::string() const { | ||
| return value == Value::IDLE ? "IDLE" | ||
| : value == Value::LOWEST ? "LOWEST" | ||
| : value == Value::LOW ? "LOW" | ||
| : value == Value::NORMAL ? "NORMAL" | ||
| : value == Value::HIGH ? "HIGH" | ||
| : value == Value::HIGHEST ? "HIGHEST" | ||
| : value == Value::REALTIME ? "REALTIME" | ||
| : "UNKNOWN"; | ||
| } | ||
|
|
||
| /** | ||
| * Stream the PriorityLevel to an ostream, it will output the string representation of the PriorityLevel | ||
| * | ||
| * @param os The ostream to output to | ||
| * @param level The PriorityLevel to output | ||
| * | ||
| * @return The ostream that was passed in | ||
| */ | ||
| friend std::ostream& operator<<(std::ostream& os, const PriorityLevel& level) { | ||
| return os << static_cast<std::string>(level); | ||
| } | ||
|
|
||
| // Operators to compare PriorityLevel values and PriorityLevel to Value | ||
| // clang-format off | ||
| friend constexpr bool operator<(const PriorityLevel& lhs, const PriorityLevel& rhs) { return lhs.value < rhs.value; } | ||
| friend constexpr bool operator>(const PriorityLevel& lhs, const PriorityLevel& rhs) { return lhs.value > rhs.value; } | ||
| friend constexpr bool operator<=(const PriorityLevel& lhs, const PriorityLevel& rhs) { return lhs.value <= rhs.value; } | ||
| friend constexpr bool operator>=(const PriorityLevel& lhs, const PriorityLevel& rhs) { return lhs.value >= rhs.value; } | ||
| friend constexpr bool operator==(const PriorityLevel& lhs, const PriorityLevel& rhs) { return lhs.value == rhs.value; } | ||
| friend constexpr bool operator!=(const PriorityLevel& lhs, const PriorityLevel& rhs) { return lhs.value != rhs.value; } | ||
|
|
||
| friend constexpr bool operator<(const PriorityLevel& lhs, const Value& rhs) { return lhs.value < rhs; } | ||
| friend constexpr bool operator>(const PriorityLevel& lhs, const Value& rhs) { return lhs.value > rhs; } | ||
| friend constexpr bool operator<=(const PriorityLevel& lhs, const Value& rhs) { return lhs.value <= rhs; } | ||
| friend constexpr bool operator>=(const PriorityLevel& lhs, const Value& rhs) { return lhs.value >= rhs; } | ||
| friend constexpr bool operator==(const PriorityLevel& lhs, const Value& rhs) { return lhs.value == rhs; } | ||
| friend constexpr bool operator!=(const PriorityLevel& lhs, const Value& rhs) { return lhs.value != rhs; } | ||
| friend constexpr bool operator<(const Value& lhs, const PriorityLevel& rhs) { return lhs < rhs.value; } | ||
| friend constexpr bool operator>(const Value& lhs, const PriorityLevel& rhs) { return lhs > rhs.value; } | ||
| friend constexpr bool operator<=(const Value& lhs, const PriorityLevel& rhs) { return lhs <= rhs.value; } | ||
| friend constexpr bool operator>=(const Value& lhs, const PriorityLevel& rhs) { return lhs >= rhs.value; } | ||
| friend constexpr bool operator==(const Value& lhs, const PriorityLevel& rhs) { return lhs == rhs.value; } | ||
| friend constexpr bool operator!=(const Value& lhs, const PriorityLevel& rhs) { return lhs != rhs.value; } | ||
|
|
||
| friend bool operator<(const PriorityLevel& lhs, const std::string& rhs) { return static_cast<std::string>(lhs) < rhs; } | ||
| friend bool operator>(const PriorityLevel& lhs, const std::string& rhs) { return static_cast<std::string>(lhs) > rhs; } | ||
| friend bool operator<=(const PriorityLevel& lhs, const std::string& rhs) { return static_cast<std::string>(lhs) <= rhs; } | ||
| friend bool operator>=(const PriorityLevel& lhs, const std::string& rhs) { return static_cast<std::string>(lhs) >= rhs; } | ||
| friend bool operator==(const PriorityLevel& lhs, const std::string& rhs) { return static_cast<std::string>(lhs) == rhs; } | ||
| friend bool operator!=(const PriorityLevel& lhs, const std::string& rhs) { return static_cast<std::string>(lhs) != rhs; } | ||
| friend bool operator<(const std::string& lhs, const PriorityLevel& rhs) { return lhs < static_cast<std::string>(rhs); } | ||
| friend bool operator>(const std::string& lhs, const PriorityLevel& rhs) { return lhs > static_cast<std::string>(rhs); } | ||
| friend bool operator<=(const std::string& lhs, const PriorityLevel& rhs) { return lhs <= static_cast<std::string>(rhs); } | ||
| friend bool operator>=(const std::string& lhs, const PriorityLevel& rhs) { return lhs >= static_cast<std::string>(rhs); } | ||
| friend bool operator==(const std::string& lhs, const PriorityLevel& rhs) { return lhs == static_cast<std::string>(rhs); } | ||
| friend bool operator!=(const std::string& lhs, const PriorityLevel& rhs) { return lhs != static_cast<std::string>(rhs); } | ||
| // clang-format on | ||
|
|
||
| private: | ||
| /// The stored enum value | ||
| Value value; | ||
| }; | ||
|
|
||
| } // namespace NUClear | ||
|
|
||
| #endif // NUCLEAR_PRIORITY_LEVEL_HPP | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.